Skip to content

Conversation

@mxschmitt
Copy link
Contributor

correct argument usage in fsWatcher update check

@mxschmitt mxschmitt changed the title fix fsWatcher update comparison fix(ct): fsWatcher update comparison Jun 20, 2025
Copy link
Member

@Skn0tt Skn0tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incredible that this wasn't caught by typescript!

@github-actions
Copy link
Contributor

Test results for "tests 1"

6 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-trace.spec.ts:587:5 › should indicate current test status @macos-latest-node18-1
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node20-1
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39427 passed, 822 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt merged commit ab7b18e into microsoft:main Jun 20, 2025
29 checks passed
@mxschmitt mxschmitt deleted the codex/find-and-fix-bug-in-codebase branch June 20, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants