Skip to content

Explicitly declare the dependencies #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
quangIO wants to merge 1 commit into from
Closed

Explicitly declare the dependencies #590

quangIO wants to merge 1 commit into from

Conversation

@quangIO
Copy link

@quangIO quangIO commented Jun 22, 2025

By default, npm hoist undeclared dependencies to node_modules. However, this behavior doesn't apply to pnpm. This allows building with pnpm without shamefully-hoist.
@quangIO
Explicitly declare the dependencies
0139613 
By default, npm hoist undeclared dependencies to node_modules. However,
this behavior doesn't apply to pnpm. This allows building with pnpm without shamefully-hoist.
@pavelfeldman
Copy link
Member

pavelfeldman commented Jun 22, 2025

  • We don't use pnpm and it is not covered in the tests, so it will regress.
  • Different versions of playwright and playwright-core in deps is a recipe for disaster!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@quangIO @pavelfeldman