Skip to content

Fix deadlock in layered FS for migrated files#903

Merged
jaybosamiya-ms merged 2 commits into
microsoft:mainfrom
scaspin:scaspin/fix-migrate-up-deadlock
Jun 5, 2026
Merged

Fix deadlock in layered FS for migrated files#903
jaybosamiya-ms merged 2 commits into
microsoft:mainfrom
scaspin:scaspin/fix-migrate-up-deadlock

Conversation

@scaspin

@scaspin scaspin commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Fix deadlock in layered FS where the node_info_lookup lock is read-acquired and then write-acquired

@scaspin

scaspin commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@wdcui wdcui requested a review from jaybosamiya-ms June 5, 2026 21:40

@jaybosamiya-ms jaybosamiya-ms left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Shai! Good catch, let's chat more about this IRL soon. I'll mildly tweak the PR title/description, since that's what the merge queue uses as the commit message, and then will hit merge shortly.

@jaybosamiya-ms jaybosamiya-ms changed the title Test and fix deadlock Fix deadlock in layered FS for migrated files Jun 5, 2026
@jaybosamiya-ms jaybosamiya-ms enabled auto-merge June 5, 2026 22:05
@jaybosamiya-ms jaybosamiya-ms added this pull request to the merge queue Jun 5, 2026
Merged via the queue into microsoft:main with commit 3c63dcc Jun 5, 2026
8 of 9 checks passed
@wdcui

wdcui commented Jun 8, 2026

Copy link
Copy Markdown
Member

@jaybosamiya-ms should we cherry pick this one to ulitebox?

@jaybosamiya-ms

Copy link
Copy Markdown
Member

Answered IRL, but briefly: due to upcoming changes to layered FS, we don't need to cherry pick this one over rn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants