Skip to content

Reduce polymorphism resulting from unstable Node shapes #51682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rbuckton merged 11 commits into from
Dec 13, 2022
Merged

Reduce polymorphism resulting from unstable Node shapes #51682

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ab3f38a
Move .symbol to Declaration
rbuckton Nov 11, 2022
3dce669
simplify some factories
rbuckton Nov 11, 2022
5a211fa
Move localSymbol to Declaration
rbuckton Nov 11, 2022
50e3eff
Ensure JSDocContainer types are properly initialized
rbuckton Nov 17, 2022
edc564a
Move contextualType from Node to NodeLinks
rbuckton Nov 17, 2022
4c94861
Move 'locals' and 'nextContainer' out of Node
rbuckton Nov 21, 2022
39b63a1
Move 'flowNode' out of 'Node'
rbuckton Nov 21, 2022
ecb2a64
Pre-define endFlowNode/returnFlowNode
rbuckton Nov 22, 2022
f5c1ca1
Pre-define some SourceFile properties and a more stable cloneNode
rbuckton Nov 29, 2022
d4c2ef3
Don't add excess properties to type nodes in typeToTypeNode
rbuckton Nov 29, 2022
afc0496
Refactor wrapSymbolTrackerToReportForContext to improve perf
rbuckton Dec 7, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move localSymbol to Declaration
  • Loading branch information
@rbuckton
rbuckton committed Dec 13, 2022
commit 5a211fa779d6000285c3238ba327a44a0aa6cded
5 changes: 3 additions & 2 deletions src/compiler/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -901,7 +901,7 @@ export interface Node extends ReadonlyTextRange {

/** @internal */ locals?: SymbolTable; // Locals associated with node (initialized by binding)
/** @internal */ nextContainer?: Node; // Next container in declaration order (initialized by binding)
/** @internal */ localSymbol?: Symbol; // Local symbol declared by node (initialized by binding only for exported nodes)

/** @internal */ flowNode?: FlowNode; // Associated FlowNode (initialized by binding)
/** @internal */ emitNode?: EmitNode; // Associated EmitNode (initialized by transforms)
/** @internal */ contextualType?: Type; // Used to temporarily assign a contextual type during overload resolution
Expand Down Expand Up @@ -1666,7 +1666,8 @@ export type DeclarationName =

export interface Declaration extends Node {
_declarationBrand: any;
/** @internal */ symbol: Symbol; // Symbol declared by node (initialized by binding)
/** @internal */ symbol: Symbol; // Symbol declared by node (initialized by binding)
/** @internal */ localSymbol?: Symbol; // Local symbol declared by node (initialized by binding only for exported nodes)
}

export interface NamedDeclaration extends Declaration {
Expand Down