Skip to content

Improve inference for context sensitive functions in object and array literal arguments #48538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 5, 2022
Merged

Improve inference for context sensitive functions in object and array literal arguments #48538

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
19260d1
Use intra-expression inference sites in type argument inference
ahejlsberg Apr 3, 2022
ac9d334
Accept new baselines
ahejlsberg Apr 3, 2022
900ef91
Add tests
ahejlsberg Apr 3, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Accept new baselines
  • Loading branch information
@ahejlsberg
ahejlsberg committed Apr 3, 2022
commit ac9d3340123aa04c0a09c2490adda565aeb5910f
24 changes: 12 additions & 12 deletions tests/baselines/reference/contextualTypingOfOptionalMembers.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ declare function app<State, Actions extends ActionsObject<State>>(obj: Options<S
app({
>app({ state: 100, actions: { foo: s => s // Should be typed number => number }, view: (s, a) => undefined as any,}) : void
>app : <State, Actions extends ActionsObject<State>>(obj: Options<State, Actions>) => void
>{ state: 100, actions: { foo: s => s // Should be typed number => number }, view: (s, a) => undefined as any,} : { state: number; actions: { foo: (s: number) => number; }; view: (s: number, a: ActionsObject<number>) => any; }
>{ state: 100, actions: { foo: s => s // Should be typed number => number }, view: (s, a) => undefined as any,} : { state: number; actions: { foo: (s: number) => number; }; view: (s: number, a: { foo: (s: number) => number; }) => any; }

state: 100,
>state : number
Expand All @@ -43,10 +43,10 @@ app({

},
view: (s, a) => undefined as any,
>view : (s: number, a: ActionsObject<number>) => any
>(s, a) => undefined as any : (s: number, a: ActionsObject<number>) => any
>view : (s: number, a: { foo: (s: number) => number; }) => any
>(s, a) => undefined as any : (s: number, a: { foo: (s: number) => number; }) => any
>s : number
>a : ActionsObject<number>
>a : { foo: (s: number) => number; }
>undefined as any : any
>undefined : undefined

Expand Down Expand Up @@ -95,7 +95,7 @@ declare function app2<State, Actions extends ActionsObject<State>>(obj: Options2
app2({
>app2({ state: 100, actions: { foo: s => s // Should be typed number => number }, view: (s, a) => undefined as any,}) : void
>app2 : <State, Actions extends ActionsObject<State>>(obj: Options2<State, Actions>) => void
>{ state: 100, actions: { foo: s => s // Should be typed number => number }, view: (s, a) => undefined as any,} : { state: number; actions: { foo: (s: number) => number; }; view: (s: number, a: ActionsObject<number>) => any; }
>{ state: 100, actions: { foo: s => s // Should be typed number => number }, view: (s, a) => undefined as any,} : { state: number; actions: { foo: (s: number) => number; }; view: (s: number, a: { foo: (s: number) => number; }) => any; }

state: 100,
>state : number
Expand All @@ -113,10 +113,10 @@ app2({

},
view: (s, a) => undefined as any,
>view : (s: number, a: ActionsObject<number>) => any
>(s, a) => undefined as any : (s: number, a: ActionsObject<number>) => any
>view : (s: number, a: { foo: (s: number) => number; }) => any
>(s, a) => undefined as any : (s: number, a: { foo: (s: number) => number; }) => any
>s : number
>a : ActionsObject<number>
>a : { foo: (s: number) => number; }
>undefined as any : any
>undefined : undefined

Expand All @@ -134,7 +134,7 @@ declare function app3<State, Actions extends ActionsArray<State>>(obj: Options<S
app3({
>app3({ state: 100, actions: [ s => s // Should be typed number => number ], view: (s, a) => undefined as any,}) : void
>app3 : <State, Actions extends ActionsArray<State>>(obj: Options<State, Actions>) => void
>{ state: 100, actions: [ s => s // Should be typed number => number ], view: (s, a) => undefined as any,} : { state: number; actions: ((s: number) => number)[]; view: (s: number, a: ActionsArray<number>) => any; }
>{ state: 100, actions: [ s => s // Should be typed number => number ], view: (s, a) => undefined as any,} : { state: number; actions: ((s: number) => number)[]; view: (s: number, a: ((s: number) => number)[]) => any; }

state: 100,
>state : number
Expand All @@ -151,10 +151,10 @@ app3({

],
view: (s, a) => undefined as any,
>view : (s: number, a: ActionsArray<number>) => any
>(s, a) => undefined as any : (s: number, a: ActionsArray<number>) => any
>view : (s: number, a: ((s: number) => number)[]) => any
>(s, a) => undefined as any : (s: number, a: ((s: number) => number)[]) => any
>s : number
>a : ActionsArray<number>
>a : ((s: number) => number)[]
>undefined as any : any
>undefined : undefined

Expand Down