-
Notifications
You must be signed in to change notification settings - Fork 13.2k
Correctly cache tagged template objects in modules #18300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
c4b1a9d
Update emit for tagged templates to use a per-site cached template ob…
DanielRosenwasser 166af8c
Accepted baselines.
DanielRosenwasser aa634ba
Added printer test for 'new (f().x)'.
DanielRosenwasser 4beb9b0
Accepted (incorrect) baselines.
DanielRosenwasser 6a9fa83
Parenthesize new'd expressions based on the leftmost node (or the fir…
DanielRosenwasser c966059
Accepted baselines.
DanielRosenwasser 8fbb304
Add a test case for conditional expressions just in case.
DanielRosenwasser 7871e08
Accepted baselines.
DanielRosenwasser 9f669d0
Explicit fall-through.
DanielRosenwasser e9c6dfe
Remove freezing behavior from tagged template helper.
DanielRosenwasser 1656790
Accepted baselines.
DanielRosenwasser b137f24
%s/getTemplateObject/makeTemplateObject
DanielRosenwasser 5565709
Accepted baselines.
DanielRosenwasser 9907453
Merge branch 'master' into correctlyCacheTaggedTemplates
DanielRosenwasser 1cb5eb9
Merge branch 'master' into correctlyCacheTaggedTemplates
DanielRosenwasser 886a29b
Added tests for import helpers with & without a declared template obj…
DanielRosenwasser 1841afe
Ensure that the import helper is checked for tagged templates, and up…
DanielRosenwasser 0b7538d
Accepted baselines.
DanielRosenwasser b406d54
git Merge branch 'master' into correctlyCacheTaggedTemplates
DanielRosenwasser 4ec1643
Fall back to old behavior for tagged template emit in global files.
DanielRosenwasser d039942
Accepted baselines.
DanielRosenwasser 5da45fb
Addressed code review feedback.
DanielRosenwasser f94bded
Added test for module & global examples.
DanielRosenwasser 81b3e85
Accepted baselines.
DanielRosenwasser a23d1bf
Updated helper for marginally better minification.
DanielRosenwasser e2c6aac
Accepted baselines.
DanielRosenwasser b80b2ee
Move first/last shortcuts closer to the end of the helper flags.
DanielRosenwasser babe3cb
Flatten the '__makeTemplateObject' helper to use less vertical screen…
DanielRosenwasser 8fd638c
Accepted baselines.
DanielRosenwasser File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Accepted baselines.
- Loading branch information
commit 166af8caf21c8d423cfb1f244d558e438ffac83b
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a regression. @rbuckton, any idea why we don't auto-parenthesize here?