Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Update packages, add tests, add type casts #229

Merged
merged 3 commits into from
Sep 29, 2019
Merged

Update packages, add tests, add type casts #229

merged 3 commits into from
Sep 29, 2019

Conversation

CarlosSolrac
Copy link
Contributor

  • Include PR "Added tests for signup and reset routes" written by alexhoffman617
  • Upgrade to latest packages
  • Add test script without --forceExit
  • Cast req.user as UserDocument
  • Update logger to use latest Winston syntax
@CarlosSolrac
Update packages, add tests, add type casts
008e1e0 
* Include PR "Added tests for signup and reset routes" written by alexhoffman617
* Upgrade to latest packages
* Add test script without --forceExit
* Cast req.user as UserDocument
* Update logger to use latest Winston syntax
@msftclas
Copy link

msftclas commented Sep 24, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.
@orta
Copy link
Contributor

orta commented Sep 24, 2019

CI fails look legit, but everything else seems good 👍
@peterblazejewicz
Copy link
Collaborator

@CarlosSolrac thanks for changes
peterblazejewicz
peterblazejewicz approved these changes Sep 29, 2019
View reviewed changes
Copy link
Collaborator

@peterblazejewicz peterblazejewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 with squash
@peterblazejewicz peterblazejewicz merged commit 1409fd7 into microsoft:master Sep 29, 2019
@peterblazejewicz peterblazejewicz mentioned this pull request Sep 29, 2019
Closed
brittanyferderer pushed a commit that referenced this pull request Jun 17, 2022
@CarlosSolrac @peterblazejewicz
Update packages, add tests, add type casts (#229)
58d0dbe 
- upgrade to latest packages
- cast `req.user` as `UserDocument`
- update logger to use latest Winston syntax
- disable `no-inferrable-types`, Mongoose use unified topology

Thx to @CarlosSolrac
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
4 participants
@CarlosSolrac @msftclas @orta @peterblazejewicz