Update Intl.DateTimeFormat to show options in constructor#1727
Conversation
chrisdavidmills
left a comment
There was a problem hiding this comment.
Hi @hamishwillee !
This is looking pretty good. I just had a coupleof issues here:
-
Generally we try to keep interactive examples to about 13 lines long at a maximum, otherwise they don't fit very well in the context of the rest of the page. Can you try to cut this down a bit?
-
You've got some CI failures to pick through and fix, mainly just stylistic stuff.
|
@chrisdavidmills This was already thirteen lines before I started, and showed only a fraction of what this can do :-(. I deleted a few interesting options and got it down to 14. If that is too many we might as well just just close this an accept we can't do a good job. |
|
This looks much better! You still have a CI error, but nearly there. |
|
Fixed! |
chrisdavidmills
left a comment
There was a problem hiding this comment.
Much better, thanks!
Previous example just shows default formatting based on locale, and locale with language fallback. This extends the example just a little to show how the date can be formatted using style and custom options.