Skip to content
This repository was archived by the owner on Oct 17, 2025. It is now read-only.

Update Intl.DateTimeFormat to show options in constructor#1727

Merged
chrisdavidmills merged 4 commits into
mdn:masterfrom
hamishwillee:intl-datetimeformat
Dec 4, 2020
Merged

Update Intl.DateTimeFormat to show options in constructor#1727
chrisdavidmills merged 4 commits into
mdn:masterfrom
hamishwillee:intl-datetimeformat

Conversation

@hamishwillee
Copy link
Copy Markdown
Contributor

Previous example just shows default formatting based on locale, and locale with language fallback. This extends the example just a little to show how the date can be formatted using style and custom options.

Copy link
Copy Markdown
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hamishwillee !

This is looking pretty good. I just had a coupleof issues here:

  1. Generally we try to keep interactive examples to about 13 lines long at a maximum, otherwise they don't fit very well in the context of the rest of the page. Can you try to cut this down a bit?

  2. You've got some CI failures to pick through and fix, mainly just stylistic stuff.

@hamishwillee
Copy link
Copy Markdown
Contributor Author

@chrisdavidmills This was already thirteen lines before I started, and showed only a fraction of what this can do :-(. I deleted a few interesting options and got it down to 14. If that is too many we might as well just just close this an accept we can't do a good job.

@chrisdavidmills
Copy link
Copy Markdown
Contributor

This looks much better! You still have a CI error, but nearly there.

@hamishwillee
Copy link
Copy Markdown
Contributor Author

hamishwillee commented Nov 27, 2020

Fixed!

Copy link
Copy Markdown
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, thanks!

@chrisdavidmills chrisdavidmills merged commit 07837b7 into mdn:master Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants