Notifications API actions/maxActions and friends#44184
Open
hamishwillee wants to merge 6 commits into
Open
Conversation
hamishwillee
requested review from
chrisdavidmills
and removed request for
a team
github-actions
Bot
added
Content:WebAPI
Contributor
|
Preview URLs (5 pages)
External URLs (1)URL:
(comment last updated: 2026-05-22 02:11:00) |
hamishwillee
commented
May 19, 2026
8 tasks
hamishwillee
commented
May 19, 2026
chrisdavidmills
requested changes
May 19, 2026
Contributor
chrisdavidmills
left a comment
chrisdavidmills
left a comment
There was a problem hiding this comment.
@hamishwillee, some really good updates here. I've provided a bunch of comments, but not really anything major. Enjoy!
hamishwillee
commented
May 22, 2026
hamishwillee
commented
May 22, 2026
hamishwillee
commented
May 22, 2026
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com> Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
hamishwillee
commented
May 22, 2026
| } | ||
| ``` | ||
|
|
||
| To invoke the above function at an appropriate time, you could listen to the |
Collaborator
Author
There was a problem hiding this comment.
This was just wrong.
hamishwillee
commented
May 22, 2026
|
|
||
| ## Examples | ||
|
|
||
| ### Basic usage |
Collaborator
Author
There was a problem hiding this comment.
FYI updated/added two new examples. This one is the original using await async and showing how tag is used. The second shows actions.
Collaborator
Author
|
Thanks very much Chris! Ready for another round. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FF152 supports
Notification.actionsandNotification/.maxActionsin https://bugzilla.mozilla.org/show_bug.cgi?id=1959931This does some work on those methods to make them more useful and specification compliant.
I also did some work on the top level API page to better highlight the two types of notifications and where you choose them.
There are problems with non-persistent notifications not working on mobile plaforms, so most users who aren't locking down their code to run on desktop will need to use the persistent notifications.
However the docs were written before the persistent notifications were invented.
While they mention them in the top level, the user guide is very thin.
The whole thing needs a revisit. This is what I have time for as part of FF release work.
Related docs work can be tracked in #44159