Synchronous gauge #183
Merged
Synchronous gauge #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upanitag
reviewed
Mar 5, 2025
upanitag
reviewed
Mar 5, 2025
upanitag
reviewed
Mar 5, 2025
upanitag
reviewed
Mar 5, 2025
upanitag
reviewed
Mar 5, 2025
upanitag
reviewed
Mar 5, 2025
upanitag
reviewed
Mar 5, 2025
upanitag
reviewed
Mar 5, 2025
upanitag
reviewed
Mar 5, 2025
upanitag
reviewed
Mar 5, 2025
upanitag
reviewed
Mar 5, 2025
upanitag
reviewed
Mar 5, 2025
duncanpo
added
refactoring
upanitag
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to add a new metric instrument, gauge.
In using gauge from otel-cpp, we need to bump up to use the ABI version 2, apparently because of some backward incompatibility. However, that backward incompatibility does not seem to affect our usage of otel-cpp.
I also added gauge to our metric example, as well as added tests and performance tests.
The code is mostly parallel to other synchronous metric instruments such as Counter or UpDownCounter, and therefore the code change is straightforward.