Make envtest.sh executable and add shebang#200
Merged
Conversation
On macOS, tests running the `envtest.sh` script would fail with a permission denied exception because the script is not exectuable: ``` System.ComponentModel.Win32Exception: Permission denied at Interop.Sys.ForkAndExecProcess(String filename, String[] argv, String[] envp, String cwd, Boolean redirectStdin, Boolean redirectStdout, Boolean redirectStderr, Boolean setUser, UInt32 userId, UInt32 groupId, Int32& lpChildPid, Int32& stdinFd, Int32& stdoutFd, Int32& stderrFd, Boolean shouldThrow) at System.Diagnostics.Process.StartCore(ProcessStartInfo startInfo) at System.Diagnostics.Process.Start() at Ductus.FluentDocker.Executors.ProcessExecutor`2.Execute() in Ductus.FluentDocker/Executors/ProcessExecutor.cs:line 75 at Ductus.FluentDocker.Tests.ProcessTests.ProcessEnvironmentTest.ProcessShallPassCustomEnvironment() in Ductus.FluentDocker.Tests/ProcessTests/ProcessEnvironmentTest.cs:line 24 ``` Also add `#!/bin/sh` to avoid exec format error: ``` System.ComponentModel.Win32Exception: Exec format error at System.Diagnostics.Process.ForkAndExecProcess(String filename, String[] argv, String[] envp, String cwd, Boolean redirectStdin, Boolean redirectStdout, Boolean redirectStderr, Boolean setCredentials, UInt32 userId, UInt32 groupId, UInt32[] groups, Int32& stdinFd, Int32& stdoutFd, Int32& stderrFd, Boolean usesTerminal, Boolean throwOnNoExec) at System.Diagnostics.Process.StartCore(ProcessStartInfo startInfo) at System.Diagnostics.Process.Start() at Ductus.FluentDocker.Executors.ProcessExecutor`2.Execute() in Ductus.FluentDocker/Executors/ProcessExecutor.cs:line 75 at Ductus.FluentDocker.Tests.ProcessTests.ProcessEnvironmentTest.ProcessShallPassCustomEnvironment() in Ductus.FluentDocker.Tests/ProcessTests/ProcessEnvironmentTest.cs:line 24 ```
0xced
force-pushed
the
envtest-executable
branch
from
1c2cbe3 to
2c33225
Compare
0xced
changed the title
envtest.sh executableenvtest.sh executable and add shebang
Owner
|
Hi @0xced and thanks for this PR! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS, tests running the
envtest.shscript would fail with a permission denied exception because the script is not exectuable:Also add
#!/bin/shto avoid exec format error: