Use .NET Trace for logging purposes.#171
Merged
Merged
Conversation
Contributor
Author
|
@mariotoffia Please tell me if for some reason the following pull request does not align with your vision on the topic. |
Owner
|
@Diggzinc Thanks for the PR! :) - I'll have a check tomorrow - need to do a another release tonight... |
|
hey, any updates on this one? it'd really be nice to have a working logger :) |
Owner
|
True, merging, thanks @Diggzinc for your contribution! :) |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The following pull request moves the logging capabilities of the library to the
Traceimplementation in dotnet.The previous code had issues regarding the configuration which were expressed on #170.
With this new implementation the logs generated by the library will now be available to the active
Trace.Listenerswhich can then be routed to the logging framework of choice. For example, like this.FAQ
Why
Trace.WriteLineand notDebug.WriteLine?In most implementations both will redirect to the
Trace.Listenersbut onnetcoreapp2.0the following error happens dotnet/runtime#26781Checklist: