[MLIR][NVVM] Remove constexpr qualifier from getNVVMCtaGroupKind #168552
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes constexpr qualifier from getNVVMCtaGroupKind function as llvm_unreachable cannot be used in a constexpr context. The build failures came up during post-merge CI
Member
|
@llvm/pr-subscribers-mlir-llvm @llvm/pr-subscribers-mlir Author: Pradeep Kumar (schwarzschild-radius) ChangesThis commit removes constexpr qualifier from getNVVMCtaGroupKind function as llvm_unreachable cannot be used in a constexpr context. The build failures came up during post-merge CI Full diff: https://github.com/llvm/llvm-project/pull/168552.diff 1 Files Affected:
diff --git a/mlir/lib/Dialect/LLVMIR/IR/NVVMDialect.cpp b/mlir/lib/Dialect/LLVMIR/IR/NVVMDialect.cpp
index 369305b40c689..0e620737109b8 100644
--- a/mlir/lib/Dialect/LLVMIR/IR/NVVMDialect.cpp
+++ b/mlir/lib/Dialect/LLVMIR/IR/NVVMDialect.cpp
@@ -62,7 +62,7 @@ static bool isPtrInSharedCTASpace(mlir::Value ptr) {
}
// Helper method to convert CtaGroupKind in NVVM Dialect to CtaGroupKind in LLVM
-static constexpr llvm::nvvm::CTAGroupKind
+static llvm::nvvm::CTAGroupKind
getNVVMCtaGroupKind(NVVM::CTAGroupKind ctaGroup) {
switch (ctaGroup) {
case NVVM::CTAGroupKind::CTA_1:
|
durga4github
approved these changes
Nov 18, 2025
🐧 Linux x64 Test Results
|
grypp
approved these changes
Nov 18, 2025
Collaborator
|
Sorry: I didn't see this PR before or I would have merged it instead of reverting!
When you encounter a build failure, either you can merge directly without review to unbreak the bot, or if you feel the fix needs to be reviewed we should revert the original PR in the meantime to unbreak the bots. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes constexpr qualifier from getNVVMCtaGroupKind function as llvm_unreachable cannot be used in a constexpr context. The build failures came up during post-merge CI