Skip to content

[orc-rt] Replace wrapper fn void *CallCtx arg with uint64_t CallId. #167452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2025
Merged

[orc-rt] Replace wrapper fn void *CallCtx arg with uint64_t CallId. #167452

merged 1 commit into from
Nov 11, 2025
+60 −54

Conversation

@lhames
Copy link
Contributor

@lhames lhames commented Nov 11, 2025

This argument serves as an opaque id (outside the ControllerAccess object) for a call to a wrapper function. I expect that most ControllerAccess implementations will want to use this argument as a sequence number (plain integer), for which uint64_t will be a better fit than void*. For ControllerAccess implementations that want to use a pointer, uint64_t should be sufficiently large.
@lhames
[orc-rt] Replace wrapper fn void *CallCtx arg with uint64_t CallId.
40a3b65 
This argument serves as an opaque id (outside the ControllerAccess object) for a
call to a wrapper function. I expect that most ControllerAccess implementations
will want to use this argument as a sequence number (plain integer), for which
uint64_t will be a better fit than void*. For ControllerAccess implementations
that want to use a pointer, uint64_t should be sufficiently large.
@lhames lhames merged commit 4c4b1a9 into llvm:main Nov 11, 2025
11 checks passed
@lhames lhames deleted the orc-rt-callctx-to-callid branch November 11, 2025 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@lhames