Use KeyObfuscator in VssStore.#378
Merged
Merged
Conversation
tnull
reviewed
Oct 16, 2024
tnull
reviewed
Oct 17, 2024
Collaborator
|
Needs a rebase now that #369 landed. |
Contributor
Author
|
Rebased |
tnull
reviewed
Oct 17, 2024
tnull
reviewed
Oct 17, 2024
Collaborator
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
LGTM, feel free to squash.
I added one comment to simplify the derivation a bit (and save the concat), but you're choice whether to address it while squashing (as it doesn't change anything material).
For client-side key obfuscation, improving privacy and security.
Contributor
Author
|
Squashed fixups. |
tnull
approved these changes
Oct 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based #369