Skip to content

Launch VSS, Expose build_with_vss* methods in bindings.#376

Merged
tnull merged 2 commits into
lightningdevkit:mainfrom
G8XSU:vss-bindings
Oct 17, 2024
Merged

Launch VSS, Expose build_with_vss* methods in bindings.#376
tnull merged 2 commits into
lightningdevkit:mainfrom
G8XSU:vss-bindings

Conversation

@G8XSU
Copy link
Copy Markdown
Contributor

@G8XSU G8XSU commented Oct 15, 2024

Based on #369

@G8XSU G8XSU changed the title Expose build_with_vss_store & build_with_vss_store_with_fixed_headers in bindings. Expose build_with_vss* methods in bindings. Oct 15, 2024
@G8XSU G8XSU requested a review from tnull October 15, 2024 07:20
@G8XSU G8XSU force-pushed the vss-bindings branch 2 times, most recently from fe89347 to 66bdf17 Compare October 15, 2024 18:53
@G8XSU G8XSU changed the title Expose build_with_vss* methods in bindings. Launch VSS, Expose build_with_vss* methods in bindings. Oct 15, 2024
@G8XSU G8XSU force-pushed the vss-bindings branch 2 times, most recently from 1f0a68a to 6afd993 Compare October 15, 2024 23:41
Comment thread Cargo.toml
Comment thread src/builder.rs
Comment thread src/builder.rs Outdated
Comment thread src/builder.rs Outdated
@G8XSU G8XSU force-pushed the vss-bindings branch 2 times, most recently from 8c94253 to 3a9c604 Compare October 17, 2024 00:10
@G8XSU
Copy link
Copy Markdown
Contributor Author

G8XSU commented Oct 17, 2024

CI will fail until rebased on top of #379

@G8XSU G8XSU requested a review from tnull October 17, 2024 00:16
@G8XSU G8XSU force-pushed the vss-bindings branch 2 times, most recently from 4fdddd3 to 368bf60 Compare October 17, 2024 05:27
@G8XSU
Copy link
Copy Markdown
Contributor Author

G8XSU commented Oct 17, 2024

Rebased on top #379

Comment thread bindings/ldk_node.udl Outdated
Comment thread src/lib.rs Outdated
Comment thread bindings/ldk_node.udl
@tnull
Copy link
Copy Markdown
Collaborator

tnull commented Oct 17, 2024

Needs a rebase now that #369 landed.

@tnull tnull mentioned this pull request Oct 17, 2024
12 tasks
@G8XSU G8XSU requested a review from tnull October 17, 2024 09:18
@tnull
Copy link
Copy Markdown
Collaborator

tnull commented Oct 17, 2024

Feel free to squash the fixup.

@G8XSU
Copy link
Copy Markdown
Contributor Author

G8XSU commented Oct 17, 2024

Squashed.

Copy link
Copy Markdown
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@tnull tnull merged commit 651f837 into lightningdevkit:main Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants