properly support an HTTP method of '0' #211
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #211 +/- ##
=======================================
Coverage 94.57% 94.57%
=======================================
Files 10 10
Lines 1254 1254
Branches 348 350 +2
=======================================
Hits 1186 1186
Misses 14 14
Partials 54 54 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
karenetheridge
force-pushed
the
ether/zero-method
branch
from
215e7c8 to
e003bfa
Compare
|
@karenetheridge could we add some documentation (maybe inline?) about why we are supporting this use case? |
|
Do you mean a code comment, or some pod? I thought the git comment would be sufficiently explanatory if someone wanted to dig into where this change came from. |
|
I think a code comment is something I'd find helpful. That's easier than digging through the history. I took a quick look at the RFC and it's not clear to me how you end up with a method of |
karenetheridge
force-pushed
the
ether/zero-method
branch
from
e003bfa to
ace517a
Compare
This is valid according to RFC9110: see https://datatracker.ietf.org/doc/html/rfc9110#appendix-A for the full ABNF, which is equivalent to the regex: ^[a-zA-Z0-9!#$%&'*+.^_`|~-]+$ This also matches the check in LWP::Protocol::http::request.
karenetheridge
force-pushed
the
ether/zero-method
branch
from
ace517a to
ab9213a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is valid according to RFC9110: see
https://datatracker.ietf.org/doc/html/rfc9110#appendix-A for the full ABNF, which is equivalent to the regex: ^[a-zA-Z0-9!#$%&'*+.^_`|~-]+$