Add basic camera feed #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
leonvogt
commented
Feb 24, 2025
| @preconcurrency import WebKit | ||
| import HotwireNative | ||
|
|
||
| class CustomWKUIController: NSObject, WKUIDelegate { |
There was a problem hiding this comment.
Note: I've made a mistake here!
If we create our own WKUIController like this, we will lose the built-in alert() and prompt() functionality that Hotwire provides.
Therefore, we should subclass Hotwire Native's WKUIController here.
Thanks to @joemasilotti for pointing this out!
- class CustomWKUIController: NSObject, WKUIDelegate {
+ class CustomWKUIController: WKUIController {| @@ -11,6 +11,7 @@ class HotwireCentral { | |||
| private init() { | |||
| configureHotwire() | |||
| self.navigator = Navigator() | |||
| self.navigator.webkitUIDelegate = CustomWKUIController() | |||
There was a problem hiding this comment.
Since we should subclass Hotwire Native's WKUIController, we need to forward the navigator instance as a WKUIControllerDelegate to CustomWKUIController.
- self.navigator.webkitUIDelegate = CustomWKUIController()
+ self.navigator.webkitUIDelegate = CustomWKUIController(delegate: navigator)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the full code from the blog post: https://leonvogt.com/hotwire-native-camera-access