fix: filter non-callable commands in agents.go and skill.go#111
Merged
Conversation
leodido
force-pushed
the
ld/generate-fix-callable
branch
from
c3f4619 to
77aa296
Compare
leodido
changed the title
agents.go included all commands (including non-runnable parent commands) in the commands table, flags section, and env vars. skill.go had the same bug in its Available Commands section. llmstxt.go already filtered correctly. Apply isCallableCommand filtering in both files, matching llmstxt.go. Co-authored-by: Ona <no-reply@ona.com>
leodido
force-pushed
the
ld/generate-fix-callable
branch
from
77aa296 to
6a635f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
agents.goincluded all commands (including non-runnable parent commands) in the commands table, flags section, and env vars.skill.gohad the same bug in its Available Commands section — it wrote a section for every command without filtering.llmstxt.goalready filtered correctly viaisCallableCommand.This applies the same
isCallableCommandfilter to both files.How to test
go test ./generate/ -v