Skip to content

🌱 refactor: split MissionSidebar.tsx into focused sub-components#14339

Merged
kubestellar-hive[bot] merged 2 commits into
mainfrom
fix/14313
May 17, 2026
Merged

🌱 refactor: split MissionSidebar.tsx into focused sub-components#14339
kubestellar-hive[bot] merged 2 commits into
mainfrom
fix/14313

Conversation

@kubestellar-hive
Copy link
Copy Markdown
Contributor

@kubestellar-hive kubestellar-hive Bot commented May 17, 2026

Fixes #14313
Copilot AI review requested due to automatic review settings May 17, 2026 07:16
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label May 17, 2026
Copilot AI reviewed May 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
@kubestellar-prow
Copy link
Copy Markdown
Contributor

kubestellar-prow Bot commented May 17, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign eeshaansa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@netlify
Copy link
Copy Markdown

netlify Bot commented May 17, 2026 •
edited
Loading

✅ Deploy Preview for kubestellarconsole ready!

Name Link
🔨 Latest commit 2ee1669
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/6a096fafe1664200083963b1
😎 Deploy Preview https://deploy-preview-14339.console-deploy-preview.kubestellar.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 17, 2026

👋 Hey @kubestellar-hive[bot] — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

This is an automated message.
@github-actions github-actions Bot added ai-generated Pull request generated by AI tier/2-standard labels May 17, 2026
@kubestellar-prow kubestellar-prow Bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 17, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 17, 2026 •
edited
Loading

⚠️ Test Coverage Gaps

4 new file(s) have no matching test. This is informational — it will not block merge.

To add tests, see the test patterns in CLAUDE.md and existing examples
in web/src/hooks/__tests__/.

Components (4 untested)

New file Suggested test location
web/src/components/layout/mission-sidebar/MissionListPanel.tsx web/src/components/layout/mission-sidebar/__tests__/MissionListPanel.test.tsx
web/src/components/layout/mission-sidebar/MissionResolution.tsx web/src/components/layout/mission-sidebar/__tests__/MissionResolution.test.tsx
web/src/components/layout/mission-sidebar/SidebarResizeHandle.tsx web/src/components/layout/mission-sidebar/__tests__/SidebarResizeHandle.test.tsx
web/src/components/layout/mission-sidebar/useSidebarResize.ts web/src/components/layout/mission-sidebar/__tests__/useSidebarResize.test.tsx

Checked against origin/main. Remove the needs-tests label once tests are added.
@github-actions github-actions Bot added the needs-tests PR adds source files without corresponding tests label May 17, 2026
github-code-quality[bot]
github-code-quality Bot found potential problems May 17, 2026
View reviewed changes
Comment thread web/src/components/layout/mission-sidebar/MissionListPanel.tsx Fixed
kubestellar-bot and others added 2 commits May 17, 2026 07:34
� refactor: split MissionSidebar.tsx into focused sub-components
2384c39 
Extract clearly separable concerns from the 1877-line MissionSidebar.tsx:

- useSidebarResize.ts: drag-to-resize hook with width persistence,
  viewport clamping, and tablet breakpoint detection
- SidebarResizeHandle.tsx: the resize drag-handle UI element
- MissionResolution.tsx: fullscreen knowledge/resolution side panel
  (saved missions list + related/history resolution panels)
- MissionListPanel.tsx: scrollable mission history/library list
  (search, orbit button, saved missions, active missions, pagination)

MissionSidebar.tsx shrinks from 1877 → 1551 lines and becomes
a leaner orchestrator that composes the sub-components.

No behavioral changes — same props, same rendering, same functionality.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: kubestellar-bot <kubestellar-bot@kubestellar.io>
🌱 fix: resolve TypeScript errors in MissionSidebar refactor
2ee1669 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: kubestellar-bot <kubestellar-bot@kubestellar.io>
@kubestellar-hive kubestellar-hive Bot mentioned this pull request May 17, 2026
Closed
@kubestellar-hive kubestellar-hive Bot merged commit 1f8bf87 into main May 17, 2026
30 of 32 checks passed
@kubestellar-prow kubestellar-prow Bot deleted the fix/14313 branch May 17, 2026 07:55
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 17, 2026

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 17, 2026

Post-merge build verification passed ✅

Both Go and frontend builds compiled successfully against merge commit 1f8bf8722df72fcadb59b94262aea237965a640d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated Pull request generated by AI copilot dco-signoff: yes Indicates the PR's author has signed the DCO. needs-tests PR adds source files without corresponding tests size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tier/2-standard

1 participant