Skip to content

🌱 Deduplicate competitor landing page shells#14017

Merged
kubestellar-hive[bot] merged 2 commits into
mainfrom
fix/14014-dedupe-competitor-shells
May 16, 2026
Merged

🌱 Deduplicate competitor landing page shells#14017
kubestellar-hive[bot] merged 2 commits into
mainfrom
fix/14014-dedupe-competitor-shells

Conversation

@kubestellar-hive
Copy link
Copy Markdown
Contributor

@kubestellar-hive kubestellar-hive Bot commented May 16, 2026 •
edited
Loading

Fixes #14014

Summary

Extract shared CompetitorLandingPage component to eliminate duplication between FromHeadlamp.tsx and FromLens.tsx.

Both pages now use a single parameterized shell component, passing competitor-specific config (branding, content, analytics callbacks) while sharing the page structure (hero, comparison table, highlights, deploy section, footer CTA).

Changes

  • Created web/src/components/landing/CompetitorLandingPage.tsx — single reusable page shell
  • Created web/src/components/landing/types.ts — strict config interface
  • Refactored FromHeadlamp.tsx to use shared component
  • Refactored FromLens.tsx to use shared component

Testing

CI will validate build and lint checks.

All competitor-specific content (branding, analytics callbacks, comparison data) is preserved and passed via config objects.
🌱 Deduplicate competitor landing page shells
d15752e 
Refactor FromHeadlamp and FromLens to use a shared CompetitorLandingPage shell while preserving page-specific content and analytics wiring.

Add typed landing config/callback contracts and regression tests for shared shell and per-page analytics isolation.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: kubestellar-bot <kubestellar-bot@kubestellar.io>
Copilot AI review requested due to automatic review settings May 16, 2026 02:55
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label May 16, 2026
Copilot AI reviewed May 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
@netlify
Copy link
Copy Markdown

netlify Bot commented May 16, 2026 •
edited
Loading

✅ Deploy Preview for kubestellarconsole ready!

Name Link
🔨 Latest commit f881f7f
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/6a07e164bb5a260008976f75
😎 Deploy Preview https://deploy-preview-14017.console-deploy-preview.kubestellar.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.
@kubestellar-prow
Copy link
Copy Markdown
Contributor

kubestellar-prow Bot commented May 16, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 16, 2026

👋 Hey @kubestellar-hive[bot] — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

This is an automated message.
@github-actions github-actions Bot added copilot tier/2-standard ai-generated Pull request generated by AI labels May 16, 2026
@kubestellar-prow kubestellar-prow Bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 16, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 16, 2026

✅ Test Coverage Check

All new source files in this PR have corresponding test files.

Checked web/src/hooks/ and web/src/components/ against origin/main.
fix: replace arbitrary Tailwind color to-[#0f172a] with to-slate-950
f881f7f 
Signed-off-by: kubestellar-bot <kubestellar-bot@kubestellar.io>
@kubestellar-hive kubestellar-hive Bot mentioned this pull request May 16, 2026
Closed
@kubestellar-hive kubestellar-hive Bot merged commit c9e0807 into main May 16, 2026
31 of 32 checks passed
@kubestellar-prow kubestellar-prow Bot deleted the fix/14014-dedupe-competitor-shells branch May 16, 2026 03:37
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 16, 2026

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 16, 2026

✅ Post-Merge Verification: passed

Commit: c9e08079e72407a83bd53bc83caf19bd9c24f230
Specs run: smoke.spec.ts
Report: https://github.com/kubestellar/console/actions/runs/25951797091
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 16, 2026

Post-merge build verification passed ✅

Both Go and frontend builds compiled successfully against merge commit c9e08079e72407a83bd53bc83caf19bd9c24f230.
@clubanderson clubanderson mentioned this pull request May 16, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated Pull request generated by AI copilot dco-signoff: yes Indicates the PR's author has signed the DCO. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tier/2-standard

1 participant