Skip to content

🐛 Fix OPAPolicies broken mode badge when status has no mode#13587

Merged
kubestellar-hive[bot] merged 2 commits into
mainfrom
fix/13584
May 14, 2026
Merged

🐛 Fix OPAPolicies broken mode badge when status has no mode#13587
kubestellar-hive[bot] merged 2 commits into
mainfrom
fix/13584

Conversation

@kubestellar-hive
Copy link
Copy Markdown
Contributor

@kubestellar-hive kubestellar-hive Bot commented May 14, 2026

Fixes #13584

Guards against rendering a mode badge when policy status has neither modes nor mode property.
🐛 Fix OPAPolicies broken mode badge when status lacks modes and mode
cd808c4 
Guard against rendering a mode badge when policy status has neither
modes nor mode property, preventing broken/empty badge display.

Fixes #13584

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 14, 2026 12:25
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label May 14, 2026
Copilot AI reviewed May 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
@netlify
Copy link
Copy Markdown

netlify Bot commented May 14, 2026 •
edited
Loading

✅ Deploy Preview for kubestellarconsole ready!

Name Link
🔨 Latest commit 6888b68
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/6a05c27b6710580008dfc8d6
😎 Deploy Preview https://deploy-preview-13587.console-deploy-preview.kubestellar.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.
@kubestellar-prow
Copy link
Copy Markdown
Contributor

kubestellar-prow Bot commented May 14, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign eeshaansa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 14, 2026
@github-actions github-actions Bot added copilot ai-generated Pull request generated by AI labels May 14, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2026

👋 Hey @kubestellar-hive[bot] — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

This is an automated message.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2026

✅ Test Coverage Check

All new source files in this PR have corresponding test files.

Checked web/src/hooks/ and web/src/components/ against origin/main.
🐛 Fix build error in OPAPolicies mode badge guard
6888b68 
TypeScript error: incompatible types in ternary expression.
status.modes is Array<'warn'|'enforce'|'dryrun'> but status.mode
includes 'deny', causing type mismatch when creating [status.mode].

Solution: Use IIFE with explicit return type to satisfy TypeScript's
type inference.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com>
@kubestellar-hive
Copy link
Copy Markdown
Contributor Author

kubestellar-hive Bot commented May 14, 2026

sec-check ✅ LGTM

No security concerns. Simple null-safety fix that prevents .map() from being called on undefined when status.mode is absent.
@kubestellar-hive kubestellar-hive Bot merged commit 69d9a11 into main May 14, 2026
31 of 33 checks passed
@kubestellar-prow kubestellar-prow Bot deleted the fix/13584 branch May 14, 2026 12:58
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2026

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2026

Post-merge build verification passed ✅

Both Go and frontend builds compiled successfully against merge commit 69d9a1178b53b0aa52768641e6d4cebbfbd1f8d5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated Pull request generated by AI copilot dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tier/2-standard

2 participants