Skip to content

fix: use console.error for permanent disconnect in useActiveUsers#13509

Merged
kubestellar-hive[bot] merged 1 commit into
kubestellar:mainfrom
AdeshDeshmukh:fix/activeusers-console-error
May 13, 2026
Merged

fix: use console.error for permanent disconnect in useActiveUsers#13509
kubestellar-hive[bot] merged 1 commit into
kubestellar:mainfrom
AdeshDeshmukh:fix/activeusers-console-error

Conversation

@AdeshDeshmukh
Copy link
Copy Markdown
Contributor

@AdeshDeshmukh AdeshDeshmukh commented May 13, 2026

Same as the update-progress hook — a max-retries-exceeded
disconnect means the presence tracker is permanently offline. It
was logging at warn, same level as a routine reconnection.

Bumped to console.error. Terminal events should surface as errors.
@AdeshDeshmukh
fix: use console.error for permanent presence disconnect failure
9408c07 
When the active-users presence WebSocket exhausts retries and stops,
it logged at warn — same severity as a temporary blip. This is a
terminal event: presence tracking is offline and won't recover.
Operators need error-level visibility.

Signed-off-by: AdeshDeshmukh <adeshkd123@gmail.com>
Copilot AI review requested due to automatic review settings May 13, 2026 22:08
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label May 13, 2026
@kubestellar-prow
Copy link
Copy Markdown
Contributor

kubestellar-prow Bot commented May 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mikespreitzer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@netlify
Copy link
Copy Markdown

netlify Bot commented May 13, 2026 •
edited
Loading

✅ Deploy Preview for kubestellarconsole ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9408c07
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/6a04f64b25d3d30009d787a5
😎 Deploy Preview https://deploy-preview-13509.console-deploy-preview.kubestellar.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.
@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 13, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

👋 Hey @AdeshDeshmukh — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

This is an automated message.
Copilot AI reviewed May 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Single-line log severity bump in the active-users presence WebSocket hook: when the reconnect loop exhausts its max attempts, the message is now emitted via console.error instead of console.warn to reflect that the presence tracker is permanently offline (mirroring the same change previously made in the update-progress hook).

Changes:

  • Promote permanent-disconnect log from console.warn to console.error in startPresenceConnection.
kubestellar-hive[bot]
kubestellar-hive Bot approved these changes May 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@kubestellar-hive kubestellar-hive Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ sec-check: PASS

Trivial log-level change (warn→error) for permanent disconnect. No security implications — no new inputs, no logic changes, no secrets exposed.
@kubestellar-prow
Copy link
Copy Markdown
Contributor

kubestellar-prow Bot commented May 13, 2026

@kubestellar-hive[bot]: changing LGTM is restricted to collaborators

Details

In response to this:

✅ sec-check: PASS

Trivial log-level change (warn→error) for permanent disconnect. No security implications — no new inputs, no logic changes, no secrets exposed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
kubestellar-hive[bot]
kubestellar-hive Bot approved these changes May 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@kubestellar-hive kubestellar-hive Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Security review: LGTM. Trivial log-level change (warn→error) for permanent disconnect. No security implications.
@kubestellar-prow
Copy link
Copy Markdown
Contributor

kubestellar-prow Bot commented May 13, 2026

@kubestellar-hive[bot]: changing LGTM is restricted to collaborators

Details

In response to this:

✅ Security review: LGTM. Trivial log-level change (warn→error) for permanent disconnect. No security implications.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
kubestellar-hive[bot]
kubestellar-hive Bot approved these changes May 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@kubestellar-hive kubestellar-hive Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — same pattern as #13508, terminal disconnect elevated to console.error. CI green.
@kubestellar-prow
Copy link
Copy Markdown
Contributor

kubestellar-prow Bot commented May 13, 2026

@kubestellar-hive[bot]: changing LGTM is restricted to collaborators

Details

In response to this:

LGTM — same pattern as #13508, terminal disconnect elevated to console.error. CI green.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
kubestellar-hive[bot]
kubestellar-hive Bot approved these changes May 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@kubestellar-hive kubestellar-hive Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Security review: PASS

Trivial log-level change (warn→error) for permanent WebSocket disconnect. No security implications — no new inputs, no data exposure, no control flow changes.
@kubestellar-prow
Copy link
Copy Markdown
Contributor

kubestellar-prow Bot commented May 13, 2026

@kubestellar-hive[bot]: changing LGTM is restricted to collaborators

Details

In response to this:

✅ Security review: PASS

Trivial log-level change (warn→error) for permanent WebSocket disconnect. No security implications — no new inputs, no data exposure, no control flow changes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
kubestellar-hive[bot]
kubestellar-hive Bot approved these changes May 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@kubestellar-hive kubestellar-hive Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Security review: PASS

Trivial log-level change (console.warn → console.error) for permanent disconnect. No logic, data flow, or security impact. LGTM.
@kubestellar-prow
Copy link
Copy Markdown
Contributor

kubestellar-prow Bot commented May 13, 2026

@kubestellar-hive[bot]: changing LGTM is restricted to collaborators

Details

In response to this:

✅ Security review: PASS

Trivial log-level change (console.warn → console.error) for permanent disconnect. No logic, data flow, or security impact. LGTM.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@kubestellar-hive kubestellar-hive Bot merged commit 2ce3e2b into kubestellar:main May 13, 2026
40 of 42 checks passed
@kubestellar-hive
Copy link
Copy Markdown
Contributor

kubestellar-hive Bot commented May 13, 2026

Thanks @AdeshDeshmukh! 🎉 Same principle, same clean fix — terminal disconnect events belong at error level. Merged via squash.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

✅ Post-Merge Verification: passed

Commit: 2ce3e2b06c611df91cf97070332ee2b748457b9b
Specs run: smoke.spec.ts
Report: https://github.com/kubestellar/console/actions/runs/25830610490
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tier/2-standard

2 participants

@AdeshDeshmukh