Skip to content

✨ Replace raw button elements with shared Button component#13469

Merged
kubestellar-hive[bot] merged 1 commit into
mainfrom
fix/13466
May 13, 2026
Merged

✨ Replace raw button elements with shared Button component#13469
kubestellar-hive[bot] merged 1 commit into
mainfrom
fix/13466

Conversation

@kubestellar-hive
Copy link
Copy Markdown
Contributor

@kubestellar-hive kubestellar-hive Bot commented May 13, 2026

Fixes #13466

Standardizes button component patterns detected as inconsistent by Auto-QA.

Changes

  • Converted raw <button> elements to use shared Button component in:
    • KubeGalaga.tsx: Pause button (secondary variant)
    • FlappyPod.tsx: New Game button (ghost variant, icon-only) and Play Again button (accent variant)
    • UpgradeStatus.tsx: Start Upgrade button (accent variant with full width)

Impact

  • Reduces inconsistency from 470 raw buttons to 466
  • Improves visual consistency across game cards and upgrade status
  • Uses semantic variants (secondary, ghost, accent) appropriate to button context
  • Maintains all existing functionality, event handlers, and accessibility attributes
  • Follows project convention to use shared UI components

Testing

CI will validate build and lint. Visual verification can be done by:

  1. Starting the console in demo mode
  2. Navigating to the Kube Galaga, Flappy Pod, and Upgrade Status cards
  3. Verifying buttons render correctly and remain functional

Size: S (23 insertions, 16 deletions)

Copilot AI review requested due to automatic review settings May 13, 2026 14:22
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label May 13, 2026
@kubestellar-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mikespreitzer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 13, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented May 13, 2026

Deploy Preview for kubestellarconsole ready!

Name Link
🔨 Latest commit 8d0c525
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/6a048b8feeb8390008f4bc02
😎 Deploy Preview https://deploy-preview-13469.console-deploy-preview.kubestellar.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added copilot tier/2-standard ai-generated Pull request generated by AI labels May 13, 2026
@github-actions
Copy link
Copy Markdown
Contributor

👋 Hey @kubestellar-hive[bot] — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.


This is an automated message.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

@kubestellar-hive kubestellar-hive Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔒 Security review: PASS

UI refactoring only — replaces raw <button> elements with the shared <Button> component in 3 files. No new logic, no new endpoints, no user-controlled data flows, no secrets. Safe to merge.

@kubestellar-hive
Copy link
Copy Markdown
Contributor Author

🔒 Security review: PASS

Replaces raw <button> elements with the shared Button component in FlappyPod, KubeGalaga, and UpgradeStatus. All variants (ghost, accent, secondary) and props (icon, fullWidth, size) are valid per the Button interface. No new event handlers, no XSS vectors, no logic changes — purely visual refactor. Safe to merge.

@kubestellar-hive kubestellar-hive Bot merged commit 4833f25 into main May 13, 2026
33 of 34 checks passed
@kubestellar-prow kubestellar-prow Bot deleted the fix/13466 branch May 13, 2026 15:00
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

@github-actions
Copy link
Copy Markdown
Contributor

❌ Post-Merge Verification: failed

Commit: 4833f25c65163bf5b450da1eb88bd68d52b3b39d
Specs run: Dashboard.spec.ts smoke.spec.ts
Report: https://github.com/kubestellar/console/actions/runs/25807440284

@github-actions
Copy link
Copy Markdown
Contributor

Post-merge build verification passed

Both Go and frontend builds compiled successfully against merge commit 4833f25c65163bf5b450da1eb88bd68d52b3b39d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated Pull request generated by AI copilot dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tier/2-standard

2 participants