Skip to content

🐛 sec: Fix nil-slice JSON serialization in store layer (12 instances)#13426

Merged
kubestellar-hive[bot] merged 1 commit into
mainfrom
fix/13422-nil-slices
May 13, 2026
Merged

🐛 sec: Fix nil-slice JSON serialization in store layer (12 instances)#13426
kubestellar-hive[bot] merged 1 commit into
mainfrom
fix/13422-nil-slices

Conversation

@kubestellar-hive
Copy link
Copy Markdown
Contributor

@kubestellar-hive kubestellar-hive Bot commented May 13, 2026

Fixes #13422

Replace var x []T with make([]T, 0) in 4 store files so empty result sets serialize as JSON [] instead of null.

Fixed instances (12):

File Function
sqlite_dashboards.go GetUserDashboards
sqlite_dashboards.go GetUserCardHistory
sqlite_dashboards.go GetRecentEvents
sqlite_features.go GetUserFeatureRequests
sqlite_features.go GetAllFeatureRequests
sqlite_features.go GetPRFeedback
sqlite_features.go GetUserNotifications
sqlite_gpu.go ListGPUReservations
sqlite_gpu.go ListUserGPUReservations
sqlite_gpu.go GetUtilizationSnapshots
sqlite_gpu.go ListActiveGPUReservations
sqlite_users.go GetOnboardingResponses

Severity: LOW — affects JSON API responses when result set is empty (clients receive null instead of []).

Build verified: go build ./... passes.
🐛 Fix nil-slice JSON serialization in store layer (12 instances)
0936091 
Replace `var x []T` with `make([]T, 0)` in 4 store files to ensure
empty result sets serialize as JSON `[]` instead of `null`.

Fixed instances:
- sqlite_dashboards.go: GetUserDashboards, GetUserCardHistory, GetRecentEvents
- sqlite_features.go: GetUserFeatureRequests, GetAllFeatureRequests, GetPRFeedback, GetUserNotifications
- sqlite_gpu.go: ListGPUReservations, ListUserGPUReservations, GetUtilizationSnapshots, ListActiveGPUReservations
- sqlite_users.go: GetOnboardingResponses

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 13, 2026 05:25
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label May 13, 2026
Copilot AI reviewed May 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
@netlify
Copy link
Copy Markdown

netlify Bot commented May 13, 2026 •
edited
Loading

✅ Deploy Preview for kubestellarconsole canceled.

Name Link
🔨 Latest commit 0936091
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/6a040b40d6c5020008be9c81
@kubestellar-prow
Copy link
Copy Markdown
Contributor

kubestellar-prow Bot commented May 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mikespreitzer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

👋 Hey @kubestellar-hive[bot] — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

This is an automated message.
@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 13, 2026
@github-actions github-actions Bot added copilot ai-generated Pull request generated by AI labels May 13, 2026
@kubestellar-hive kubestellar-hive Bot merged commit 352199b into main May 13, 2026
35 of 36 checks passed
@kubestellar-hive kubestellar-hive Bot deleted the fix/13422-nil-slices branch May 13, 2026 05:35
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

Post-merge build verification passed ✅

Both Go and frontend builds compiled successfully against merge commit 352199b0985899a37e230b450f72bfd3b4231e52.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

✅ Post-Merge Verification: passed

Commit: 352199b0985899a37e230b450f72bfd3b4231e52
Specs run: smoke.spec.ts
Report: https://github.com/kubestellar/console/actions/runs/25780527089
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated Pull request generated by AI copilot dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tier/2-standard

2 participants