Skip to content

🐛 Wire isDemoData through useCertManager hook and CertManager card#13336

Merged
kubestellar-hive[bot] merged 1 commit into
mainfrom
fix-13335-certmanager-isDemoData
May 12, 2026
Merged

🐛 Wire isDemoData through useCertManager hook and CertManager card#13336
kubestellar-hive[bot] merged 1 commit into
mainfrom
fix-13335-certmanager-isDemoData

Conversation

@kubestellar-hive
Copy link
Copy Markdown
Contributor

@kubestellar-hive kubestellar-hive Bot commented May 12, 2026

Fixes #13335

What

The CertManager card in DataComplianceCards.tsx was calling useCardLoadingState() without isDemoData, causing demo data to render without the Demo badge and yellow outline.

Changes

  • web/src/hooks/useCertManager.ts: Add isDemoData state tracking — true when demo mode is active, false on successful live data fetch. Added to hook return value.
  • web/src/components/cards/DataComplianceCards.tsx: Destructure isDemoData from useCertManager() and pass it to useCardLoadingState() in the CertManager component.

Testing

  • When demo mode is active: CertManager card should show Demo badge + yellow outline
  • When live data is fetched: no Demo badge
  • When cert-manager is not installed: appropriate install prompt (unchanged behavior)
🐛 Wire isDemoData through useCertManager hook and CertManager card
bff89cf 
The CertManager card in DataComplianceCards.tsx was calling
useCardLoadingState() without isDemoData, causing demo data to render
without the Demo badge and yellow outline.

- Add isDemoData state to useCertManager hook
- Set isDemoData=true in demo mode path
- Set isDemoData=false on successful live data fetch
- Pass isDemoData to useCardLoadingState in CertManager component

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Copilot <copilot@github.com>
Copilot AI review requested due to automatic review settings May 12, 2026 20:39
Copilot AI reviewed May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
@kubestellar-prow
Copy link
Copy Markdown
Contributor

kubestellar-prow Bot commented May 12, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label May 12, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented May 12, 2026 •
edited
Loading

✅ Deploy Preview for kubestellarconsole ready!

Name Link
🔨 Latest commit bff89cf
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/6a039011018e13000790d5e2
😎 Deploy Preview https://deploy-preview-13336.console-deploy-preview.kubestellar.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.
@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 12, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026

👋 Hey @kubestellar-hive[bot] — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

This is an automated message.
@github-actions github-actions Bot added copilot ai-generated Pull request generated by AI labels May 12, 2026
@kubestellar-hive kubestellar-hive Bot merged commit 9abc904 into main May 12, 2026
37 of 38 checks passed
@kubestellar-prow kubestellar-prow Bot deleted the fix-13335-certmanager-isDemoData branch May 12, 2026 20:54
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026

Post-merge build verification passed ✅

Both Go and frontend builds compiled successfully against merge commit 9abc904d25ba5ad6d60b7458c917b3c244108844.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026

❌ Post-Merge Verification: failed

Commit: 9abc904d25ba5ad6d60b7458c917b3c244108844
Specs run: Dashboard.spec.ts smoke.spec.ts
Report: https://github.com/kubestellar/console/actions/runs/25761626665
@github-actions github-actions Bot mentioned this pull request May 12, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated Pull request generated by AI copilot dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tier/2-standard

1 participant