Skip to content

🌱 Add useLLMd priority test for vllm-deployment detection#13292

Merged
kubestellar-hive[bot] merged 1 commit into
mainfrom
fix/13285
May 12, 2026
Merged

🌱 Add useLLMd priority test for vllm-deployment detection#13292
kubestellar-hive[bot] merged 1 commit into
mainfrom
fix/13285

Conversation

@kubestellar-hive
Copy link
Copy Markdown
Contributor

@kubestellar-hive kubestellar-hive Bot commented May 12, 2026

Fixes #13285

Adds a regression test to verify that detectServerType('vllm-deployment') resolves to 'vllm' instead of matching the llm-d substring first, and aligns the cached helper with that priority ordering.
🌱 Add useLLMd priority test for vllm-deployment detection
9e2e3b3 
Cover the vllm-deployment regression case in cached LLMd server detection and keep vllm matching ahead of llm-d substring detection.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Copilot <copilot@github.com>
Copilot AI review requested due to automatic review settings May 12, 2026 13:00
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label May 12, 2026
Copilot AI reviewed May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
@kubestellar-prow
Copy link
Copy Markdown
Contributor

kubestellar-prow Bot commented May 12, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mikespreitzer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 12, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented May 12, 2026 •
edited
Loading

✅ Deploy Preview for kubestellarconsole ready!

Name Link
🔨 Latest commit 9e2e3b3
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/6a0324643caca60008bfc99b
😎 Deploy Preview https://deploy-preview-13292.console-deploy-preview.kubestellar.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026

👋 Hey @kubestellar-hive[bot] — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

This is an automated message.
@github-actions github-actions Bot added copilot ai-generated Pull request generated by AI labels May 12, 2026
kubestellar-hive[bot]
kubestellar-hive Bot commented May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@kubestellar-hive kubestellar-hive Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Review: LGTM — correct fix reordering detectServerType() to check vllm before llm-d, preventing substring match bug. Test covers the regression.
@kubestellar-hive kubestellar-hive Bot merged commit 773911a into main May 12, 2026
34 of 36 checks passed
@kubestellar-prow kubestellar-prow Bot deleted the fix/13285 branch May 12, 2026 13:10
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026

❌ Post-Merge Verification: failed

Commit: 773911a0a793ed4b5b1bd3c33ae842170270577d
Specs run: smoke.spec.ts
Report: https://github.com/kubestellar/console/actions/runs/25736637007
@github-actions github-actions Bot mentioned this pull request May 12, 2026
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026

Post-merge build verification passed ✅

Both Go and frontend builds compiled successfully against merge commit 773911a0a793ed4b5b1bd3c33ae842170270577d.
@kubestellar-hive kubestellar-hive Bot mentioned this pull request May 12, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated Pull request generated by AI copilot dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tier/2-standard

1 participant