Skip to content

fix(i18n): LocalClustersSection defaultValue hides missing keys#13160

Merged
kubestellar-hive[bot] merged 1 commit into
mainfrom
fix/13154
May 11, 2026
Merged

fix(i18n): LocalClustersSection defaultValue hides missing keys#13160
kubestellar-hive[bot] merged 1 commit into
mainfrom
fix/13154

Conversation

@kubestellar-hive
Copy link
Copy Markdown
Contributor

@kubestellar-hive kubestellar-hive Bot commented May 11, 2026

Fixes #13154

Changes

Remove defaultValue: '' from both t() calls in getVClusterActionMessage in LocalClustersSection.tsx.

When a translation key is missing, react-i18next normally falls back to the key name — making the gap visible. Passing defaultValue: '' overrides that behaviour and renders a silent empty string, which hides missing translation coverage.
Copilot AI review requested due to automatic review settings May 11, 2026 18:27
Copilot AI reviewed May 11, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label May 11, 2026
@kubestellar-prow
Copy link
Copy Markdown
Contributor

kubestellar-prow Bot commented May 11, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign eeshaansa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

👋 Hey @kubestellar-hive[bot] — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

This is an automated message.
@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 11, 2026
@github-actions github-actions Bot added ai-generated Pull request generated by AI copilot tier/2-standard labels May 11, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented May 11, 2026 •
edited
Loading

✅ Deploy Preview for kubestellarconsole ready!

Name Link
🔨 Latest commit 9646454
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/6a022623d05b170008249f13
😎 Deploy Preview https://deploy-preview-13160.console-deploy-preview.kubestellar.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.
fix(i18n): LocalClustersSection defaultValue hides missing keys
9646454 
Remove defaultValue: '' from both t() calls in getVClusterActionMessage.
The empty-string default silently renders blank when a key is missing;
without it, react-i18next falls back to the key name, making translation
gaps visible during development.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Copilot <copilot@github.com>
@kubestellar-hive kubestellar-hive Bot merged commit 1d0a935 into main May 11, 2026
30 of 31 checks passed
@kubestellar-prow kubestellar-prow Bot deleted the fix/13154 branch May 11, 2026 19:23
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

❌ Post-Merge Verification: failed

Commit: 1d0a935a872c10508275d3ef5f8641b7dd568ba5
Specs run: Settings.spec.ts smoke.spec.ts
Report: https://github.com/kubestellar/console/actions/runs/25692122179
@github-actions github-actions Bot mentioned this pull request May 11, 2026
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

Post-merge build verification passed ✅

Both Go and frontend builds compiled successfully against merge commit 1d0a935a872c10508275d3ef5f8641b7dd568ba5.
Hridyansh7193 pushed a commit to Hridyansh7193/console_lfx that referenced this pull request May 11, 2026
@kubestellar-hive @Hridyansh7193
fix(i18n): LocalClustersSection defaultValue hides missing keys (kube…
df88e63 
…stellar#13160)

Remove defaultValue: '' from both t() calls in getVClusterActionMessage.
The empty-string default silently renders blank when a key is missing;
without it, react-i18next falls back to the key name, making translation
gaps visible during development.

Signed-off-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated Pull request generated by AI copilot dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tier/2-standard

1 participant