Skip to content

fix: autonomous banner uses hardcoded strings#13159

Merged
kubestellar-hive[bot] merged 1 commit into
mainfrom
fix/13153
May 11, 2026
Merged

fix: autonomous banner uses hardcoded strings#13159
kubestellar-hive[bot] merged 1 commit into
mainfrom
fix/13153

Conversation

@kubestellar-hive
Copy link
Copy Markdown
Contributor

@kubestellar-hive kubestellar-hive Bot commented May 11, 2026

Fixes #13153

Changes

  • Moves AUTONOMOUS_BANNER_STORAGE_KEY from inside the component function to lib/constants/storage.ts as STORAGE_KEY_AUTONOMOUS_BANNER_DISMISSED — eliminates the per-render string allocation
  • Adds layout.autonomousBannerMessage, layout.watchLive, and layout.watchLiveMobile keys to locales/en/common.json
  • Replaces all three hardcoded English strings in the autonomous banner with t() calls
fix(i18n): replace hardcoded strings in autonomous banner
c76f441 
- Move AUTONOMOUS_BANNER_STORAGE_KEY out of component scope to
  lib/constants/storage.ts to avoid recreating it on every render
- Add layout.autonomousBannerMessage, layout.watchLive, and
  layout.watchLiveMobile keys to locales/en/common.json
- Replace hardcoded English banner strings with t() calls

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Copilot <copilot@github.com>
Copilot AI review requested due to automatic review settings May 11, 2026 18:26
Copilot AI reviewed May 11, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label May 11, 2026
@kubestellar-prow
Copy link
Copy Markdown
Contributor

kubestellar-prow Bot commented May 11, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@netlify
Copy link
Copy Markdown

netlify Bot commented May 11, 2026 •
edited
Loading

✅ Deploy Preview for kubestellarconsole ready!

Name Link
🔨 Latest commit c76f441
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/6a021f57ff9f5f0008b768e7
😎 Deploy Preview https://deploy-preview-13159.console-deploy-preview.kubestellar.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

👋 Hey @kubestellar-hive[bot] — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

This is an automated message.
@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 11, 2026
@github-actions github-actions Bot added ai-generated Pull request generated by AI tier/2-standard copilot labels May 11, 2026
@kubestellar-hive kubestellar-hive Bot merged commit 7ead67f into main May 11, 2026
36 of 37 checks passed
@kubestellar-prow kubestellar-prow Bot deleted the fix/13153 branch May 11, 2026 18:55
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

Post-merge build verification passed ✅

Both Go and frontend builds compiled successfully against merge commit 7ead67f7d753a8c0730ebf898ac2c624e920be2a.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

❌ Post-Merge Verification: failed

Commit: 7ead67f7d753a8c0730ebf898ac2c624e920be2a
Specs run: navbar-responsive.spec.ts smoke.spec.ts
Report: https://github.com/kubestellar/console/actions/runs/25690733579
@github-actions github-actions Bot mentioned this pull request May 11, 2026
Closed
Hridyansh7193 pushed a commit to Hridyansh7193/console_lfx that referenced this pull request May 11, 2026
@kubestellar-hive @Hridyansh7193
fix(i18n): replace hardcoded strings in autonomous banner (kubestella…
43c5c5a 
…r#13159)

- Move AUTONOMOUS_BANNER_STORAGE_KEY out of component scope to
  lib/constants/storage.ts to avoid recreating it on every render
- Add layout.autonomousBannerMessage, layout.watchLive, and
  layout.watchLiveMobile keys to locales/en/common.json
- Replace hardcoded English banner strings with t() calls

Signed-off-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated Pull request generated by AI copilot dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tier/2-standard

1 participant