Skip to content

🐛 Sync critical issues badge with actual data#12972

Merged
kubestellar-hive[bot] merged 2 commits into
mainfrom
fix/12971
May 10, 2026
Merged

🐛 Sync critical issues badge with actual data#12972
kubestellar-hive[bot] merged 2 commits into
mainfrom
fix/12971

Conversation

@kubestellar-hive
Copy link
Copy Markdown
Contributor

@kubestellar-hive kubestellar-hive Bot commented May 10, 2026 •
edited
Loading

Fixes #12971

The critical issues badge in the page header was showing a count that did not match the Critical stat card. This fix ensures both use the same data source.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com
🐛 Don't count backend disconnection as critical in demo/offline mode
671ba96 
The DashboardHealthIndicator badge was counting backend disconnection
as a critical issue even in demo mode, where disconnection is the
expected state. This created a contradiction: badge shows 'X critical
issues' while page stat cards show '0 critical' because they count
from actual data sources.

Now backend disconnection is only counted as critical when:
- Not in demo mode (disconnection is unexpected)
- Agent was previously connected (user had connectivity and lost it)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Copilot <copilot@github.com>
@kubestellar-hive kubestellar-hive Bot requested review from Copilot and removed request for Copilot May 10, 2026 15:33
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label May 10, 2026
@kubestellar-prow
Copy link
Copy Markdown
Contributor

kubestellar-prow Bot commented May 10, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mikespreitzer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@netlify
Copy link
Copy Markdown

netlify Bot commented May 10, 2026 •
edited
Loading

✅ Deploy Preview for kubestellarconsole ready!

Name Link
🔨 Latest commit 3a1a6c3
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/6a00a5d341cd3d0008cb254c
😎 Deploy Preview https://deploy-preview-12972.console-deploy-preview.kubestellar.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.
@github-actions github-actions Bot added tier/2-standard copilot ai-generated Pull request generated by AI labels May 10, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 10, 2026

👋 Hey @kubestellar-hive[bot] — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

This is an automated message.
@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 10, 2026
🐛 Sync critical issues badge with actual data on Insights page
3a1a6c3 
Use page-specific header badges on Insights and Clusters so the header reflects the same source as each page's stats.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Copilot <copilot@github.com>
@kubestellar-hive kubestellar-hive Bot requested review from Copilot and removed request for Copilot May 10, 2026 15:35
@kubestellar-prow kubestellar-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 10, 2026
@kubestellar-hive kubestellar-hive Bot changed the title 🐛 Don't count backend disconnection as critical in demo/offline mode 🐛 Sync critical issues badge with actual data May 10, 2026
@kubestellar-hive kubestellar-hive Bot merged commit 8ba859a into main May 10, 2026
33 of 34 checks passed
@kubestellar-prow kubestellar-prow Bot deleted the fix/12971 branch May 10, 2026 15:49
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 10, 2026

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 10, 2026

Post-merge build verification passed ✅

Both Go and frontend builds compiled successfully against merge commit 8ba859af2e705042f07ae22898dfcb7098d91810.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 10, 2026

✅ Post-Merge Verification: passed

Commit: 8ba859af2e705042f07ae22898dfcb7098d91810
Specs run: Clusters.spec.ts smoke.spec.ts
Report: https://github.com/kubestellar/console/actions/runs/25633003674
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated Pull request generated by AI copilot dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tier/2-standard

0 participants