Skip to content

🐛 Fix navbar agent status indicator to show connection state#12858

Merged
kubestellar-hive[bot] merged 1 commit into
mainfrom
fix/12856
May 9, 2026
Merged

🐛 Fix navbar agent status indicator to show connection state#12858
kubestellar-hive[bot] merged 1 commit into
mainfrom
fix/12856

Conversation

@kubestellar-hive
Copy link
Copy Markdown
Contributor

@kubestellar-hive kubestellar-hive Bot commented May 9, 2026

Fixes #12856

Summary

The AgentStatusIndicator pill was modified in #12641 to prioritize dashboardHealth.status over agent connection status, causing the pill to display cluster health counts (e.g. '7 critical issues') instead of agent connectivity state.

Changes

  • Reorder pill config so agent connection states (degraded, connected, etc.) take priority over dashboard health
  • Remove dashboard health branches from pill label — they no longer override the pill text
  • Keep systemHealthTooltip wired to connected state tooltip so health info is accessible via hover
  • Remove dashboardHealth.status === 'healthy' guard from connecting spinner
🐛 Fix navbar agent status indicator to show connection state over das…
e5a2357 
…hboard health

The AgentStatusIndicator pill was modified in #12641 to prioritize dashboard
health metrics over agent connection status. This caused the pill to display
cluster alert counts instead of agent connectivity state.

Revert pill label to show agent connection status (Connected, Degraded, etc.)
while keeping system health info accessible via the hover tooltip.

Fixes #12856

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Copilot <copilot@github.com>
@kubestellar-hive kubestellar-hive Bot requested review from Copilot and removed request for Copilot May 9, 2026 20:58
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label May 9, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented May 9, 2026 •
edited
Loading

✅ Deploy Preview for kubestellarconsole ready!

Name Link
🔨 Latest commit e5a2357
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/69ff9fe07fe3c30008fa0e35
😎 Deploy Preview https://deploy-preview-12858.console-deploy-preview.kubestellar.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.
@kubestellar-prow
Copy link
Copy Markdown
Contributor

kubestellar-prow Bot commented May 9, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mikespreitzer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 9, 2026

👋 Hey @kubestellar-hive[bot] — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

This is an automated message.
@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 9, 2026
@github-actions github-actions Bot added tier/2-standard copilot ai-generated Pull request generated by AI labels May 9, 2026
@kubestellar-hive kubestellar-hive Bot merged commit d96adf6 into main May 9, 2026
36 of 37 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 9, 2026

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey
@kubestellar-hive kubestellar-hive Bot mentioned this pull request May 9, 2026
Closed
7 tasks
@kubestellar-prow kubestellar-prow Bot deleted the fix/12856 branch May 9, 2026 21:21
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 9, 2026

Post-merge build verification passed ✅

Both Go and frontend builds compiled successfully against merge commit d96adf6c0cf9d2411f50179e7605dc2c7291c636.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 9, 2026

❌ Post-Merge Verification: failed

Commit: d96adf6c0cf9d2411f50179e7605dc2c7291c636
Specs run: navbar-responsive.spec.ts smoke.spec.ts
Report: https://github.com/kubestellar/console/actions/runs/25612636747
@github-actions github-actions Bot mentioned this pull request May 9, 2026
Closed
kubestellar-hive Bot pushed a commit that referenced this pull request May 9, 2026
🐛 Fix test failures from Coverage Suite run #2416
c3cb5a3 
Restore sidebar defaults when the server-side dashboard filter is cleared, while still keeping filtered defaults hidden only when the filter is active. Also update the AgentStatusIndicator test to match the intended connection-state precedence from #12858.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Signed-off-by: Copilot <copilot@github.com>
kubestellar-hive Bot added a commit that referenced this pull request May 9, 2026
@kubestellar-hive
🐛 Fix test failures from Coverage Suite run #2416 (#12875)
5503282 
Restore sidebar defaults when the server-side dashboard filter is cleared, while still keeping filtered defaults hidden only when the filter is active. Also update the AgentStatusIndicator test to match the intended connection-state precedence from #12858.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Signed-off-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated Pull request generated by AI copilot dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tier/2-standard

0 participants