Skip to content

Developer Guide: Refresh e2e testing documents for kubetest2#5045

Merged
k8s-ci-robot merged 3 commits into
kubernetes:masterfrom
pymander:dev-guide-e2e-testing
Sep 2, 2020
Merged

Developer Guide: Refresh e2e testing documents for kubetest2#5045
k8s-ci-robot merged 3 commits into
kubernetes:masterfrom
pymander:dev-guide-e2e-testing

Conversation

@pymander
Copy link
Copy Markdown
Contributor

This change creates a new file with e2e testing documentation for the
new kubetest2 test runner. Once kubetest is retired, this can drop
right into the existing e2e developer guide docs.

Which issue(s) this PR fixes:

Fixes #

This change creates a new file with e2e testing documentation for the
new kubetest2 test runner. Once kubetest is retired, this can drop
right into the existing e2e developer guide docs.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 18, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @pymander. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 18, 2020
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Aug 18, 2020
@pymander
Copy link
Copy Markdown
Contributor Author

/assign @amwat

Copy link
Copy Markdown
Contributor

@amwat amwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for creating this guide!
/ok-to-test

FYI @BenTheElder @spiffxp

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 18, 2020
Copy link
Copy Markdown
Contributor

@amwat amwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great and detailed!

Comment thread contributors/devel/sig-testing/e2e-tests-kubetest2.md
Comment thread contributors/devel/sig-testing/e2e-tests-kubetest2.md Outdated
Comment thread contributors/devel/sig-testing/e2e-tests-kubetest2.md Outdated
Comment thread contributors/devel/sig-testing/e2e-tests-kubetest2.md
Comment thread contributors/devel/sig-testing/e2e-tests-kubetest2.md
This addresses some suggested changes to the kubetest2 getting started guide.
@pymander
Copy link
Copy Markdown
Contributor Author

/assign amwat

This change adds details on building with kubetest2 and without --legacy-mode.
Copy link
Copy Markdown
Contributor

@amwat amwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great start! Thanks.
We can definitely keep iterating on this as and when things change.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2020
@amwat
Copy link
Copy Markdown
Contributor

amwat commented Sep 1, 2020

/assign @BenTheElder @spiffxp
for approval

Copy link
Copy Markdown
Contributor

@amwat amwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one optional addition: perhaps we can point out somewhere that build up down test can also be used all at once.

e.g. kubetest2 gce --build --up --down --test=ginkgo -- --focus-regex "\[Feature:Performance\]"

@pymander
Copy link
Copy Markdown
Contributor Author

pymander commented Sep 1, 2020 via email

@pymander
Copy link
Copy Markdown
Contributor Author

pymander commented Sep 1, 2020

Wow, that is amazing! Okay, I'll try it by hand.

Copy link
Copy Markdown
Contributor

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pymander, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2020
@k8s-ci-robot k8s-ci-robot merged commit e08e5a2 into kubernetes:master Sep 2, 2020
@pymander pymander deleted the dev-guide-e2e-testing branch September 2, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/developer-guide Issues or PRs related to the developer guide cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

5 participants