Skip to content

Fix missing renames of Bootstrap.list_bootstraps -> Bootstrap.all_bootstraps#2066

Merged
opacam merged 1 commit into
kivy:developfrom
touilleMan:fix-Bootstrap.all_bootstraps-use
Feb 21, 2020
Merged

Fix missing renames of Bootstrap.list_bootstraps -> Bootstrap.all_bootstraps#2066
opacam merged 1 commit into
kivy:developfrom
touilleMan:fix-Bootstrap.all_bootstraps-use

Conversation

@touilleMan
Copy link
Copy Markdown
Contributor

@touilleMan touilleMan commented Feb 21, 2020

Fixes p4a bootstrap command:

$ p4a bootstraps
Traceback (most recent call last):
  File "/home/touilleman/projects/buildozer-test/venv/bin/p4a", line 10, in <module>
    sys.exit(main())
  File "/home/touilleman/projects/buildozer-test/venv/lib/python3.7/site-packages/pythonforandroid/entrypoints.py", line 18, in main
    ToolchainCL()
  File "/home/touilleman/projects/buildozer-test/venv/lib/python3.7/site-packages/pythonforandroid/toolchain.py", line 671, in __init__
    getattr(self, args.subparser_name.replace('-', '_'))(args)
  File "/home/touilleman/projects/buildozer-test/venv/lib/python3.7/site-packages/pythonforandroid/toolchain.py", line 788, in bootstraps
    for bs in Bootstrap.list_bootstraps():
AttributeError: type object 'Bootstrap' has no attribute 'list_bootstraps'
@opacam
Copy link
Copy Markdown
Member

opacam commented Feb 21, 2020

Thanks!! 😄,

Do you mind to rename as well this list_bootstraps entry 😬?

opacam
opacam previously approved these changes Feb 21, 2020
Copy link
Copy Markdown
Member

@opacam opacam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Note: it would be awesome if we could change the docstring I mentioned before in this PR, so we could have all the renames of list_boostraps concentrated at same PR.

@touilleMan
Copy link
Copy Markdown
Contributor Author

@opacam I've update my PR to correct the docstring ;-)

Copy link
Copy Markdown
Member

@opacam opacam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Thanks again!!! 😄

@opacam opacam merged commit 8740267 into kivy:develop Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants