Skip to content

fix(datetime): display today's date and time when value is an empty string #29839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandyscarney merged 4 commits into from
Sep 6, 2024
Merged

fix(datetime): display today's date and time when value is an empty string #29839

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dec4f80
fix(datetime): display today's date and time when value is an empty s…
brandyscarney Sep 5, 2024
24a6ace
test(datetime): add a test to check the displayed date when value is …
brandyscarney Sep 5, 2024
5865584
style: lint
brandyscarney Sep 5, 2024
e38dbc9
Update core/src/components/datetime/datetime.tsx
brandyscarney Sep 6, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
style: lint
  • Loading branch information
@brandyscarney
brandyscarney committed Sep 5, 2024
commit 5865584112a4e0936913d6d0ffaf005877be46a0
2 changes: 1 addition & 1 deletion core/src/components/datetime/test/basic/datetime.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
await expect(datetime).toHaveJSProperty('value', '2022-10-01T16:22:00');
});

test('should display today\'s date and time when value is an empty string', async ({ page }) => {
test("should display today's date and time when value is an empty string", async ({ page }) => {
await page.setContent(
`
<ion-datetime locale="en-US" presentation="date-time" value=""></ion-datetime>
Expand Down