Skip to content

fix(item): router-link remains clickable with item cover #29743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

brandyscarney
Copy link
Member

Issue number: N/A


What is the current behavior?

Item includes ion-anchor in the list of clickable components it queries. This component was renamed to ion-router-link in v5.

What is the new behavior?

Updates the reference to ion-anchor to ion-router-link in ion-item.

Does this introduce a breaking change?

  • Yes
  • No
Copy link

vercel bot commented Jul 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 9:07pm
@brandyscarney brandyscarney marked this pull request as ready for review July 31, 2024 21:07
@brandyscarney brandyscarney requested a review from a team as a code owner July 31, 2024 21:07
@github-actions github-actions bot added the package: core @ionic/core package label Jul 31, 2024
@sean-perkins
Copy link
Contributor

Subject line could be: fix(item): router-link stays clickable with item cover or similar.

@brandyscarney brandyscarney changed the title fix(item): check for ion-router-link instead of ion-anchor fix(item): router-link remains clickable with item cover Aug 1, 2024
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandyscarney brandyscarney added this pull request to the merge queue Aug 5, 2024
Merged via the queue into main with commit a9f278a Aug 5, 2024
49 checks passed
@brandyscarney brandyscarney deleted the fix-item-anchor branch August 5, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
3 participants