fix: consistent counts at proceedings and proceedings/attendees#10935
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10935 +/- ##
==========================================
+ Coverage 88.51% 88.52% +0.01%
==========================================
Files 332 332
Lines 44970 44950 -20
==========================================
- Hits 39805 39792 -13
+ Misses 5165 5158 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rpcross
left a comment
rpcross
left a comment
There was a problem hiding this comment.
Possible proceedings/attendees/ view inconsistencies.
| remote_count = len(remote) | ||
| remote_pks = frozenset(p.pk for p in remote) | ||
|
|
||
| regs = list( |
There was a problem hiding this comment.
Here registrations is being calculated separately and differently than stats so the totals may not match the table data. For example stats.onsite (from meeting.get_attendees().online) would include someone who registered onsite, did not checkin, and attended a session (Attended), whereas registrations would not.
There was a problem hiding this comment.
Ok - the reconstruction of Registration objects here is overly complicated anyhow. e1a84da makes it wholly dependent on the people returned by get_attendees.
jennifer-richards
left a comment
jennifer-richards
left a comment
There was a problem hiding this comment.
Approving. One minor comment inline, but not an essential change.
| ) | ||
| attendees_by_att = set( | ||
| Person.objects.filter(attended_per_meeting_attended).values_list( | ||
| Person.objects.filter(attended__session__in=sessions).values_list( |
There was a problem hiding this comment.
There's no guard that sessions are attached to this Meeting. May want to check that and fail with an assertion (or at least a logged error).
(You could also filter sessions to the current meeting, but I think a mix-up like this probably would indicate a more serious logic error somewhere.)
3 participants
This causes proceedings/attendees to show all attendees, not just those for whom the attendance is nomcom qualifying.
It refactors how attendance is calculated for proceedings, proceedings/attendees, and three_of_five_eligible9389
It fixes a bug (that had no consequence of previous nomcom choices) that counted hackathon only attendance towards nomcom eligibility.
I've independently checked that, except for the bug above which affected only two people, the results for three_of_five_eligible9389 remain unchanged for sets of 5 from [110...115] to [121...125].
Claude was used in creating this PR