Skip to content

feat: process rfc-editor queue notifications from purple#10857

Merged
jennifer-richards merged 13 commits into
ietf-tools:mainfrom
rjsparks:new_rfced_queue
May 14, 2026
Merged

feat: process rfc-editor queue notifications from purple#10857
jennifer-richards merged 13 commits into
ietf-tools:mainfrom
rjsparks:new_rfced_queue

Conversation

@rjsparks

Copy link
Copy Markdown
Member

This adds an endpoint that accepts a post of the queue json and passes it to a celery task which updates all of the documents in the queue (and those that had been in the queue but no longer are) accordingly.

It follows similar logic to the old queue processor, but changes things so that only two new draft-rfceditor states are used: in_progress and blocked. It adds a new DocEvent derivative RpcAssignmentDocEvent that captures, in text form, roughly what the new queue site shows in its Status column.

Note well that the first time the new queue is processed, any documents with old draft-rfceditor states will be updated to the new states and the new status values will be added as an RpcAssignmentDocEvent, leading to a pair of email messages to each subscriber using the community tool to watch for changes to the document. At the time of development slightly more than 4000 messages would have been emitted.

Claude was used heavily in the creation of this PR.

@codecov

codecov Bot commented May 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.92473% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.49%. Comparing base (473bbb2) to head (45062c5).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
ietf/sync/tasks.py 98.52% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #10857    +/-   ##
========================================
  Coverage   88.49%   88.49%            
========================================
  Files         332      332            
  Lines       44851    44973   +122     
========================================
+ Hits        39690    39801   +111     
- Misses       5161     5172    +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@jjrauch32-lab

This comment was marked as spam.

jjrauch32-lab

This comment was marked as spam.

@jennifer-richards jennifer-richards left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally good. A couple nits (one just an aesthetic suggestion, disregard if you prefer). A couple questions about tests, including several about a state that I don't think is valid in the queue json input.

Comment thread ietf/doc/migrations/0037_rpcassignmentdocevent.py Outdated
Comment thread ietf/sync/tasks.py Outdated
Comment thread ietf/sync/tests_tasks.py Outdated
Comment thread ietf/sync/tests_tasks.py Outdated
[
{
"name": draft.name,
"assignment_set": [{"role": "blocked", "state": "blocked"}],

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again the "state": "blocked"

Comment thread ietf/sync/tests_tasks.py Outdated
Comment thread ietf/sync/tests_tasks.py Outdated

@jennifer-richards jennifer-richards left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The tests are a little oddly organized / named but they cover the necessary cases.

@jennifer-richards

Copy link
Copy Markdown
Member

Waiting for compatibility testing with purple's side of the API before merging

@jennifer-richards
jennifer-richards merged commit d51c909 into ietf-tools:main May 14, 2026
9 checks passed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants