add redirect on package.tar.gz download #698
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This breaks some tests, they'll need to be fixed. |
|
Let's hold off on this one for a bit to get us more time to consider the consequences for Hackage clients out there... |
|
Indeed, we're blocked on at least changes to the hackage-security backends, and perhaps other tools as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #659
The approach here is different than in that ticket. We just check if there is a "?real=true" at the end of the .tar.gz url. If there isn't, we bump the download count and redirect to a url that does have the path. If there is, then we just return the .tar.gz.
That way the cdn can cache the real url, and everything works as is.