Make searches paginated

[414owen]

Previously, searches only returned the first thirty results, and there was no way to access page two.

Note that this is a breaking API change.

[andreasabel]

Excellent!
There should be something added to the testsuite using the new API. Can you look into adding tests, @414owen?

[andreasabel]

@Mergifyio rebase

[mergify]

rebase

✅ Branch has been successfully rebased

[andreasabel]

Please supply a testcase or a demo in samples/.

[414owen]

@andreasabel I've fixed up the existing samples, will this do?

[andreasabel]

Good job!
Could you please add the samples to the executables in samples/github-samples.cabal so that they get built by the CI.
Concerning the tests you added, unfortunately they do not run at the moment on CI, see https://github.com/haskell-github/github/runs/6098329674?check_suite_focus=true#step:20:144 and issue

• cabal test succeeds silently if no GITHUB_TOKEN is set #478.

[andreasabel]

I think you doubled this line by accident.

[414owen]

Trying to use the github-samples.cabal project locally errors with Could not find module ‘Github’, but I presume CI will have more luck.

change needed: s/Github/GitHub/g

[414owen]

@andreasabel Looks like code search is broken in master, because the repository field doesn't line up 1:1 with the Repo datatype.

I've fixed it in this branch, by adding a new CodeSearchRepo type.

[andreasabel]

Weird error message by GHC 8 and 9 in CI failure (https://github.com/haskell-github/github/runs/6228048459?check_suite_focus=true#step:18:153):

Building executable 'github-search-repos' for github-samples-0..
[1 of 1] Compiling Main             ( Search/SearchRepos.hs, /__w/github/github/dist-newstyle/build/x86_64-linux/ghc-9.2.2/github-samples-0/x/github-search-repos/noopt/build/github-search-repos/github-search-repos-tmp/Main.o )

Search/SearchRepos.hs:43:34: error:
    Ambiguous occurrence ‘GitHub.repoName’
    It could refer to
       either the field ‘repoName’,
              imported qualified from ‘GitHub’ at Search/SearchRepos.hs:4:1-23
              (and originally defined in ‘GitHub.Data.Repos’)
           or the field ‘repoName’,
              imported qualified from ‘GitHub’ at Search/SearchRepos.hs:4:1-23
              (and originally defined in ‘GitHub.Data.Repos’)
   |
43 |   let fields = [ ("Name", show . GitHub.repoName)
   |                                  ^^^^^^^^^^^^^^^

GHC 7.8 / 7.10 fail with (https://github.com/haskell-github/github/runs/6228049019?check_suite_focus=true#step:18:46):

Building library for github-0.27.1..

src/GitHub/Data/Repos.hs:3:14:
    Unsupported extension: DuplicateRecordFields

[andreasabel]

Maybe don't use the DuplicateRecordFields extension. Are there strong reasons to use it?

[414owen]

Not really, I used DuplicateRecordFields so I could copy-paste Repo fields into CodeSearchRepo fields. I'll remove it now.

[414owen]

Ugh, GHC-7 semigroup issue -_-
One sec...

[andreasabel]

Thanks, @414owen , looks like everything is ready. Squashing is ok? (Since there are fixup commits...)

[414owen]

Sure thing!