Feature/create pull comment #320
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/createPullComment
|
Ping! This capability keeps me off master, are there any objections? |
|
Superseded by #350 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is actually two concepts for us to discuss and merge or rework depending on the outcome of the discussion.
Pull Request Line Comments
We now have
NewPullCommentandcreatePullComment :: Auth -> Name Owner -> Name Repo -> Id Issue -> Text -> Text -> Int -> Text -> IO (Either Error Comment)where we have a commit hash, file path, position, and a body.Pull Request Diffs
Obtaining pull request diffs (github diffs) requires use of a new accept header. The diff provided via a URL is not a git diff and therefore unsuitable for calculating line numbers for the position value needed by
createPullComment.