Skip to content

aws_ecr_images - add new datasource - Fixes #42576 #42577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

psantus
Copy link
Contributor

@psantus psantus commented May 12, 2025

Description

Add new data source to list ECR images in a repository

Relations

Fixes #42576

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

2025/05/12 12:59:02 Initializing Terraform AWS Provider...
=== RUN TestAccECRImagesDataSource_basic
=== PAUSE TestAccECRImagesDataSource_basic
=== RUN TestAccECRImagesDataSource_publicRepo
=== PAUSE TestAccECRImagesDataSource_publicRepo
=== CONT TestAccECRImagesDataSource_basic
=== CONT TestAccECRImagesDataSource_publicRepo
--- PASS: TestAccECRImagesDataSource_basic (21.34s)
--- PASS: TestAccECRImagesDataSource_publicRepo (24.50s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ecr 28.380s

@psantus psantus requested a review from a team as a code owner May 12, 2025 11:52
Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.
Copy link

github-actions bot commented May 12, 2025

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ecr Issues and PRs that pertain to the ecr service. generators Relates to code generators. size/XL Managed by automation to categorize the size of a PR. labels May 12, 2025
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels May 12, 2025
@psantus psantus closed this May 23, 2025
@psantus psantus deleted the f-data_aws_ecr_images-add-datasource branch May 23, 2025 21:18
Copy link

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@psantus psantus restored the f-data_aws_ecr_images-add-datasource branch May 23, 2025 21:39
@psantus psantus reopened this May 23, 2025
@psantus
Copy link
Contributor Author

psantus commented May 23, 2025

Closed by mistake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. service/ecr Issues and PRs that pertain to the ecr service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
2 participants