feat(writeEarlyHints): handle object-format early hints#202
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #202 +/- ##
==========================================
- Coverage 78.55% 76.97% -1.59%
==========================================
Files 19 19
Lines 1054 1077 +23
Branches 208 208
==========================================
+ Hits 828 829 +1
- Misses 226 248 +22
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
pi0
reviewed
Oct 17, 2022
pi0
changed the title
danielroe
commented
Oct 17, 2022
danielroe
commented
Oct 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
subsequent to previous implementation, nodejs/node#44820 made format object-based. this pr aligns h3 with node's current implementation
before nodejs/node#44874 is released, we also have to manually replace crossorigin attribute 🤦