Skip to content

fix(3678): executor must respect commit_docs:false; teach SDK skip envelope #3679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trek-e merged 4 commits into from
May 18, 2026
+284 −3
Merged

fix(3678): executor must respect commit_docs:false; teach SDK skip envelope #3679

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
88cb3e9
fix(3678): executor must respect commit_docs:false; teach SDK skip en…
trek-e May 17, 2026
799d91f
chore(changeset): add fragment for #3678 fix (Co-Authored-By: Claude …
trek-e May 17, 2026
335f5ad
chore(changeset): set PR number 3679 (Co-Authored-By: Claude Opus 4.7…
trek-e May 17, 2026
330d693
fix(3678): preserve skip-aware carve-out in executor completion check…
trek-e May 18, 2026
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore(changeset): set PR number 3679 (Co-Authored-By: Claude Opus 4.7… 
… (1M context) <noreply@anthropic.com>)
  • Loading branch information
@trek-e
trek-e committed May 17, 2026
commit 335f5ade64a8846c1abc0a79f2d7f96655c26bd5
2 changes: 1 addition & 1 deletion .changeset/fix-3678-commit-docs-respect.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
type: Fixed
pr: 0
pr: 3679
---
**`gsd-executor` no longer force-commits `.planning/` artifacts when `commit_docs: false`** — the executor agent prompt now explicitly handles the SDK's `{committed:false, skipped:true, reason:'skipped_commit_docs_false'}` envelope and is forbidden from falling back to raw `git add` / `git add -f` / `git commit`. The SDK's `cmdCommit` now sets `skipped: true` on both skip paths (`commit_docs:false` and `.planning gitignored`) so agents see the skip as a first-class signal. A structural regression test bans `git add -f` / `git add --force` from any agent or workflow body. (#3678)
Loading