test(spanner): propagate errors from 'Transaction.batch_update' #9393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That API can fail without raising an exception (it returns a status code and a list of rows affected by each successfull DML statuement). We would like for our retry mechanism to operate, so raise an exception for non-zero status inside our unit-of-work function. Closes #7504
googlebot
added
the
cla: yes
larkee
approved these changes
Oct 18, 2019
Contributor
larkee
left a comment
larkee
left a comment
There was a problem hiding this comment.
LGTM assuming the import order is correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That API can fail without raising an exception (it returns a status code
and a list of rows affected by each successfull DML statuement).
We would like for our retry mechanism to operate, so raise an exception
for non-zero status inside our unit-of-work function.
Closes #7504