Skip to content

wrong ready status#584

Merged
barnettZQG merged 1 commit into
goodrain:V5.1from
GLYASAI:initprobe
Dec 13, 2019
Merged

wrong ready status#584
barnettZQG merged 1 commit into
goodrain:V5.1from
GLYASAI:initprobe

Conversation

@GLYASAI

@GLYASAI GLYASAI commented Dec 13, 2019

Copy link
Copy Markdown
Contributor
for _, cn := range d.dependServiceClusterNames {
    if _, ok := readyClusters[cn]; !ok {
        return false
    }
}

这个条件判断不对, 只判断了 cn 是否存在, 并没有检查 cn 对应的 value 是否为 true.
正确的判断应该是 cn 存在, 且对应的 value 为 true.

@GLYASAI GLYASAI requested a review from barnettZQG December 13, 2019 04:46

@barnettZQG barnettZQG left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked

@barnettZQG barnettZQG merged commit 32cc2ba into goodrain:V5.1 Dec 13, 2019
@GLYASAI GLYASAI deleted the initprobe branch March 6, 2020 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants