Ensure classes match their header filename#25821
Conversation
Also drop some unused files. Renamed: - `core/dvector.h` -> `pool_vector.h` - `core/io/resource_import.h` -> `resource_importer.h` - `core/sort.h` -> `sort_array.h` - `core/string_db.h` -> `string_name.h` Dropped: - `core/allocators.h` - `core/os/shell.h` - `core/variant_construct_string.cpp`
|
@akien-mga Added to my working copy of the changelog 🙂 I guess I'll send another PR before the 3.1 release. |
Renamed: - `drivers/alsamidi/alsa_midi.h` -> `midi_driver_alsamidi.h` (same for `coremidi` and `winmidi`) - `main/timer_sync.h` -> `main_timer_sync.h` - `servers/visual/visual_server_global.h` -> `visual_server_globals.h`
c9ae931 to
b1b3b59
Compare
Also drop some unused files. Renamed: - `platform/iphone/sem_iphone.h` -> `semaphore_iphone.h` (same for `osx`) - `platform/uwp/gl_context_egl.h` -> `context_egl_uwp.h` - in `platform/windows`: `context_gl_win.h`, `crash_handler_win.h`, `godot_win.cpp`, `joypad.h` and `key_mapping_win.h` all renamed to use `windows`. Some classes renamed accordingly too. - `EditorExportAndroid` and `EditorExportUWP` renamed to `EditorExportPlatformAndroid` and `EditorExportPlatformUWP` - `power_android` and `power_osx` renamed to `PowerAndroid` and `PowerOSX` - `OSUWP` renamed to `OS_UWP` Dropped: - `platform/windows/ctxgl_procaddr.h`
b1b3b59 to
bc26d0d
Compare
Also drop some unused files. Renamed: - `scene/2d/navigation2d.h` -> `navigation_2d.h` - `scene/2d/screen_button.h` -> `touch_screen_button.h` - `scene/3d/scenario_fx.h` -> `world_environment.h` - `scene/audio/audio_player.h` -> `audio_stream_player.h` - `scene/resources/bit_mask.h` -> `bit_map.h` - `scene/resources/color_ramp.h` -> `gradient.h` - `scene/resources/shape_line_2d.h` -> `line_shape_2d.h` - `scene/resources/scene_format_text.h` -> `resource_format_text.h` - `scene/resources/sky_box.h` -> `sky.h` Dropped: - `scene/resources/bounds.h`
b689884 to
c5dcbeb
Compare
|
Only In |
|
Done |
Renamed: - `modules/mono/mono_gd/gd_mono_class_member.h` -> `i_mono_class_member.h` - `modules/upnp/upnpdevice.h` -> `upnp_device.h` - `modules/websocket/websocket_multiplayer.h` -> `websocket_multiplayer_peer.h`
8566670 to
fe7e11e
Compare
Might be worth considering "Win32" because UWP is also Windows (10). Though this may be jumping the gun a bit, since I don't think UWP will become the default for at least another decade.
Why not
Wow, I've never seen gradients called "color ramp" before :P |
Don't see much use for renaming it this way, and it would be a massive change (and compat breakage for build scripts).
Most editor classes start with |
Also drop some unused files.
Core
Renamed:
core/dvector.h->pool_vector.hcore/io/resource_import.h->resource_importer.hcore/sort.h->sort_array.hcore/string_db.h->string_name.hDropped:
core/allocators.hcore/os/shell.hcore/variant_construct_string.cppDrivers, main, servers
Renamed:
drivers/alsamidi/alsa_midi.h->midi_driver_alsamidi.h(same for
coremidiandwinmidi)main/timer_sync.h->main_timer_sync.hservers/visual/visual_server_global.h->visual_server_globals.hPlatform
Renamed:
platform/iphone/sem_iphone.h->semaphore_iphone.h(same for
osx)platform/uwp/gl_context_egl.h->context_egl_uwp.hplatform/windows:context_gl_win.h,crash_handler_win.h,godot_win.cpp,joypad.handkey_mapping_win.hall renamed touse
windows. Some classes renamed accordingly too.EditorExportAndroidandEditorExportUWPrenamed toEditorExportPlatformAndroidandEditorExportPlatformUWPpower_androidandpower_osxrenamed toPowerAndroidandPowerOSXOSUWPrenamed toOS_UWPDropped:
platform/windows/ctxgl_procaddr.hScene
Renamed:
scene/2d/navigation2d.h->navigation_2d.hscene/2d/screen_button.h->touch_screen_button.hscene/3d/scenario_fx.h->world_environment.hscene/audio/audio_player.h->audio_stream_player.hscene/resources/bit_mask.h->bit_map.hscene/resources/color_ramp.h->gradient.hscene/resources/shape_line_2d.h->line_shape_2d.hscene/resources/scene_format_text.h->resource_format_text.hscene/resources/sky_box.h->sky.hDropped:
scene/resources/bounds.hModules
Renamed:
modules/mono/mono_gd/gd_mono_class_member.h->i_mono_class_member.hmodules/upnp/upnpdevice.h->upnp_device.hmodules/websocket/websocket_multiplayer.h->websocket_multiplayer_peer.hMight break compat for some thirdparty modules that include e.g.
core/dvector.horcore/io/resource_import.h, would be worth mentioning in the changelog @Calinou.