Skip to content

Conversation

@m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Jun 26, 2025

Follow-up to #105605.

The first PR attempted to enable the generation of native debug symbols, and while the symbols are generated, they are invalid and cannot be used to symbolicate the stack traces from the Play store.
This PR addresses that issue by disabling native debug symbols generation from gradle and instead using the .so files generated by scons.

Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When doing development, I like to build with scons debug_symbols=yes separate_debug_symbols=no, so that debug symbols are included in the libgodot_android.so file.

Before this PR, that work fine!

However, with this PR, if I unzip the android_sources.zip and the godot-lib.template.debug.aar, then the contained libgodot_android.so appears to be stripped of debug symbols.

Oddly, unzipping the android_debug.apk, the libgodot_android.so in there does appear to have debug symbols.

I haven't really tested the separate debug symbols, beyond that the zip file gets generated, because that's not a feature that I personally use.

@m4gr3d m4gr3d force-pushed the update_build_logic branch from 15bfed3 to 7293872 Compare June 26, 2025 18:11
@m4gr3d
Copy link
Contributor Author

m4gr3d commented Jun 26, 2025

When doing development, I like to build with scons debug_symbols=yes separate_debug_symbols=no, so that debug symbols are included in the libgodot_android.so file.

Before this PR, that work fine!

However, with this PR, if I unzip the android_sources.zip and the godot-lib.template.debug.aar, then the contained libgodot_android.so appears to be stripped of debug symbols.

Oddly, unzipping the android_debug.apk, the libgodot_android.so in there does appear to have debug symbols.

I haven't really tested the separate debug symbols, beyond that the zip file gets generated, because that's not a feature that I personally use.

@dsnopek That issue should be fixed in the latest push.

@dsnopek
Copy link
Contributor

dsnopek commented Jun 26, 2025

@dsnopek That issue should be fixed in the latest push.

Thanks! It's working for me now :-)

@m4gr3d m4gr3d force-pushed the update_build_logic branch from 7293872 to c376348 Compare July 5, 2025 17:38
Copy link
Contributor

@Repiteo Repiteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit spicy to approve for a merge right before a new snapshot, but we can roll with it

@Repiteo Repiteo merged commit 85b0061 into godotengine:master Jul 7, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jul 7, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment