-
-
Notifications
You must be signed in to change notification settings - Fork 23.8k
Android: Fix the build logic to generate the native debug symbols #107998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dsnopek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When doing development, I like to build with scons debug_symbols=yes separate_debug_symbols=no, so that debug symbols are included in the libgodot_android.so file.
Before this PR, that work fine!
However, with this PR, if I unzip the android_sources.zip and the godot-lib.template.debug.aar, then the contained libgodot_android.so appears to be stripped of debug symbols.
Oddly, unzipping the android_debug.apk, the libgodot_android.so in there does appear to have debug symbols.
I haven't really tested the separate debug symbols, beyond that the zip file gets generated, because that's not a feature that I personally use.
15bfed3 to
7293872
Compare
@dsnopek That issue should be fixed in the latest push. |
Thanks! It's working for me now :-) |
7293872 to
c376348
Compare
Repiteo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit spicy to approve for a merge right before a new snapshot, but we can roll with it
|
Thanks! |
Follow-up to #105605.
The first PR attempted to enable the generation of native debug symbols, and while the symbols are generated, they are invalid and cannot be used to symbolicate the stack traces from the Play store.
This PR addresses that issue by disabling native debug symbols generation from
gradleand instead using the.sofiles generated byscons.