Free nodes from instantiating if it is not a Control in the theme editor
#107632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Node *instance = loaded_scene->instantiate(); | ||
| if (!instance || !Object::cast_to<Control>(instance)) { | ||
|
|
Member
There was a problem hiding this comment.
I think it's fine either way here, but yeah it could be removed as the pattern:
Object *obj = get_some_object();
if (!obj) {is pretty common in Godot.
But here there's also a later if check that uses instance and so it can make sense indeed to have them separate:
Node *instance;
if (!instance) {}
if (other thing with instance) {}
AdrienUfferte
approved these changes
Jun 17, 2025
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fix on the theme editor preview.
Fix a rarely-happening minor memory leak from not freeing the instantiated node inside the if clause that checks if a node is
Control. Also added more error messages