Skip to content

Number & Currency: Add format to parts support#891

Merged
rxaviers merged 3 commits into
globalizejs:masterfrom
rxaviers:currency-to-parts
Mar 25, 2020
Merged

Number & Currency: Add format to parts support#891
rxaviers merged 3 commits into
globalizejs:masterfrom
rxaviers:currency-to-parts

Conversation

@rxaviers
Copy link
Copy Markdown
Member

@rxaviers rxaviers commented Mar 20, 2020 •
edited
Loading

  • Currency: Fix code style
  • Currency: pluralGenerator better error handling

Fixes #679
Fixes #680
@rxaviers rxaviers force-pushed the currency-to-parts branch from dd7ee4d to 058d167 Compare March 20, 2020 18:26
rxaviers
rxaviers commented Mar 20, 2020
View reviewed changes
Comment thread README.md
// ]
```

[Read more...](doc/api/number/number-to-parts-formatter.md)
Copy link
Copy Markdown
Member Author

@rxaviers rxaviers Mar 20, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add this file
@rxaviers rxaviers force-pushed the currency-to-parts branch from 058d167 to e30b498 Compare March 23, 2020 15:08
@rxaviers
Copy link
Copy Markdown
Member Author

rxaviers commented Mar 23, 2020 •
edited
Loading

  • Update README built sizes
  • Functional tests: add these new methods
@rxaviers rxaviers force-pushed the currency-to-parts branch 4 times, most recently from 43c5d9d to fb8e4e2 Compare March 24, 2020 18:52
rxaviers
rxaviers commented Mar 24, 2020
View reviewed changes
Comment thread package.json Outdated
"cldr-data-downloader": "^0.3.1",
"glob": "^7.1.2",
"globalize-compiler": "^0.3.0-alpha.6",
"globalize-compiler": "globalizejs/globalize-compiler#support-number-currency-format-to-parts",
Copy link
Copy Markdown
Member Author

@rxaviers rxaviers Mar 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Use actual globalize-compiler release
@rxaviers rxaviers force-pushed the currency-to-parts branch from a6bf717 to c4c0a56 Compare March 24, 2020 21:28
@rxaviers rxaviers mentioned this pull request Mar 25, 2020
Merged
@rxaviers rxaviers force-pushed the currency-to-parts branch 2 times, most recently from c493532 to 9f4efc5 Compare March 25, 2020 12:03
rxaviers added 2 commits March 25, 2020 09:05
@rxaviers
Number & Currency: Add format to parts support
e0eaa2c 
- Currency: Fix code style
- Currency: pluralGenerator better error handling

Fixes globalizejs#679
Fixes globalizejs#680
@rxaviers
Travis: Use Node 12
5f70a2a
@rxaviers rxaviers force-pushed the currency-to-parts branch 2 times, most recently from 8347152 to 4afcb99 Compare March 25, 2020 12:09
@rxaviers rxaviers force-pushed the currency-to-parts branch from 4afcb99 to a607631 Compare March 25, 2020 12:15
@rxaviers rxaviers merged commit 9595743 into globalizejs:master Mar 25, 2020
@X-oss-byte X-oss-byte mentioned this pull request Sep 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@rxaviers