updated app-npm-webpack example to support latest v3 version of webpack#812
Closed
ambrons wants to merge 3 commits into
Closed
updated app-npm-webpack example to support latest v3 version of webpack#812ambrons wants to merge 3 commits into
ambrons wants to merge 3 commits into
Conversation
Contributor
Author
|
I failed to mention in my initial post that I'm speculating that the reason the i18n comes after the app is that the plugin isn't able to determine that app depends on i18n as they're optional depending on which one you select and only via the vendor package, which the app has a direct dependency on. |
Contributor
Author
|
Reading over this it seems like a common problem and perhaps should just be baked into the plugin since it dictates that chunks must be used and what it's named already |
… suggestions to do. This could probably be moved into the GlobalizeWebpackPlugin except that we don't know the total breathe of chunks or imports. So it might be better here to provide a recipe instead.
Member
|
Merged thanks |
Member
|
I also did a few additional improvements 73d1d93 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP: Without reordering the chunks the application produces the following error after production compile:
That's with the order of the script injects done this way:
./dist/index.html
However if you move
app.*.jsto the end all works as it should.This was done in an effort to fix the same issue in my product after upgrading to webpack v3.x. Which has the same issue.
I looked at the back and forth in #794
And there's a few changes in there and a lot of overlap with what was done there.